Make PaymentMethod.Card.networks field public
#5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
changed the title
networks prop public
|
Diffuse output: APKDEX |
tillh-stripe
commented
Sep 14, 2022
| @@ -3567,10 +3567,12 @@ public final class com/stripe/android/model/PaymentMethod$Card : com/stripe/andr | |||
| public final field fingerprint Ljava/lang/String; | |||
| public final field funding Ljava/lang/String; | |||
| public final field last4 Ljava/lang/String; | |||
| public final field networks Lcom/stripe/android/model/PaymentMethod$Card$Networks; | |||
There was a problem hiding this comment.
Should this go into the release notes?
There was a problem hiding this comment.
I think so, is this work being done on iOS?
There was a problem hiding this comment.
Yes, let's add to the CHANGEDOC.
There was a problem hiding this comment.
@jameswoo-stripe It’s already public in the iOS repo.
tillh-stripe
requested review from
brnunes-stripe,
ccen-stripe and
jameswoo-stripe
as code owners
tillh-stripe
changed the title
networks prop publicnetworks field public
tillh-stripe
changed the title
networks field publicPaymentMethod.Card.networks field public
jameswoo-stripe
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request exposes
PaymentMethod.networks, which is also a part of Stripe’s public API.Motivation
Request from EMEA Cards team.
Testing
Changelog
tbd