Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compileSdkVersion to 33 #5495

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

jameswoo-stripe
Copy link
Contributor

Summary

Bump compileSdkVersion to 33

Motivation

Identity is complaining that compileSdkVersion is 32

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  15.4 MiB │  15.4 MiB │ -80 B │  52.1 MiB │  52.1 MiB │ +36 B 
     arsc │   1.8 MiB │   1.8 MiB │   0 B │   1.8 MiB │   1.8 MiB │   0 B 
 manifest │     4 KiB │     4 KiB │   0 B │  18.5 KiB │  18.5 KiB │   0 B 
      res │ 874.5 KiB │ 874.5 KiB │   0 B │   1.4 MiB │   1.4 MiB │   0 B 
   native │   2.5 MiB │   2.5 MiB │   0 B │   5.9 MiB │   5.9 MiB │   0 B 
    asset │     3 MiB │     3 MiB │   0 B │     3 MiB │     3 MiB │   0 B 
    other │  81.7 KiB │  81.7 KiB │   0 B │ 155.6 KiB │ 155.6 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  23.6 MiB │  23.6 MiB │ -80 B │  64.3 MiB │  64.3 MiB │ +36 B 

         │          raw           │            unique            
         ├────────┬────────┬──────┼────────┬────────┬────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff       
─────────┼────────┼────────┼──────┼────────┼────────┼────────────
   files │      4 │      4 │    0 │        │        │            
 strings │ 251755 │ 251756 │   +1 │ 214734 │ 214735 │ +1 (+1 -0) 
   types │  44408 │  44408 │    0 │  40770 │  40770 │  0 (+0 -0) 
 classes │  37967 │  37967 │    0 │  37967 │  37967 │  0 (+0 -0) 
 methods │ 222011 │ 222011 │    0 │ 214004 │ 214004 │  0 (+0 -0) 
  fields │ 163211 │ 163211 │    0 │ 162168 │ 162168 │  0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6237 │ 6237 │  0
APK
   compressed    │  uncompressed   │                
─────────┬───────┼─────────┬───────┤                
 size    │ diff  │ size    │ diff  │ path           
─────────┼───────┼─────────┼───────┼────────────────
 3.2 MiB │ -80 B │ 9.1 MiB │ +36 B │ ∆ classes4.dex 
─────────┼───────┼─────────┼───────┼────────────────
 3.2 MiB │ -80 B │ 9.1 MiB │ +36 B │ (total)
MANIFEST
@@ -1,4 +1,4 @@
 <manifest
-    android:compileSdkVersion=32
-    android:compileSdkVersionCodename=12
+    android:compileSdkVersion=33
+    android:compileSdkVersionCodename=13
     android:versionCode=9
@@ -6,4 +6,4 @@
     package=com.stripe.android.paymentsheet.example
-    platformBuildVersionCode=32
-    platformBuildVersionName=12
+    platformBuildVersionCode=33
+    platformBuildVersionName=13
     xmlns:android=http://schemas.android.com/apk/res/android
@@ -12,3 +12,3 @@
       android:minSdkVersion=21
-      android:targetSdkVersion=32
+      android:targetSdkVersion=33
       />
DEX
STRINGS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   214734 │ 214735 │ +1 (+1 -0) 
  + valueAnimator

awush-stripe
awush-stripe previously approved these changes Aug 30, 2022
tillh-stripe
tillh-stripe previously approved these changes Aug 30, 2022
Comment on lines +1 to +2
sdk=30

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why was this needed for Financial Connections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roboelectric doesn't like compileSdkVersion 33, I think all modules using Roboelectric will need this as a workaround

brnunes-stripe
brnunes-stripe previously approved these changes Aug 30, 2022
@jameswoo-stripe jameswoo-stripe force-pushed the bump-compile-sdk-version-33 branch 3 times, most recently from 870f725 to 42ff939 Compare August 30, 2022 21:48
@jameswoo-stripe jameswoo-stripe force-pushed the bump-compile-sdk-version-33 branch from 42ff939 to e1d64cd Compare August 30, 2022 22:06
ccen-stripe
ccen-stripe previously approved these changes Aug 30, 2022
@jameswoo-stripe jameswoo-stripe force-pushed the bump-compile-sdk-version-33 branch 2 times, most recently from 0ac10d6 to bcf428b Compare August 30, 2022 23:03
@jameswoo-stripe jameswoo-stripe force-pushed the bump-compile-sdk-version-33 branch from bcf428b to 42233fa Compare August 30, 2022 23:10
@jameswoo-stripe jameswoo-stripe enabled auto-merge (squash) August 30, 2022 23:30
@jameswoo-stripe jameswoo-stripe merged commit cddc0ff into master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants