Skip to content

Commit

Permalink
Ignore identity-example size diff for now
Browse files Browse the repository at this point in the history
  • Loading branch information
jameswoo-stripe committed Aug 30, 2022
1 parent e1d64cd commit bcf428b
Show file tree
Hide file tree
Showing 4 changed files with 102 additions and 97 deletions.
194 changes: 97 additions & 97 deletions .github/workflows/identity_pull_request.yml
Original file line number Diff line number Diff line change
@@ -1,97 +1,97 @@
name: identity-example size diff
on:
pull_request:
paths:
- 'identity/**'
- 'stripe-core/**'
- 'camera-core/**'
- 'dependencies.gradle'
jobs:
# Checkout base branch and build the APK
build-base:
name: Build base
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ github.base_ref }}
- name: Build base branch
run: ./gradlew :identity-example:assembleRelease && mv identity-example/build/outputs/apk/theme1/release/identity-example-theme1-release-unsigned.apk identity-example/build/outputs/apk/theme1/release/identity-example-release-base.apk
- name: Upload APK
uses: actions/upload-artifact@v1
with:
name: apk
path: identity-example/build/outputs/apk/theme1/release/identity-example-release-base.apk

# Checkout PR branch and build the APK
build-pr:
name: Build PR
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Build PR branch
run: ./gradlew :identity-example:assembleRelease && mv identity-example/build/outputs/apk/theme1/release/identity-example-theme1-release-unsigned.apk identity-example/build/outputs/apk/theme1/release/identity-example-release-pr.apk
- name: Upload APK
uses: actions/upload-artifact@v1
with:
name: apk
path: identity-example/build/outputs/apk/theme1/release/identity-example-release-pr.apk

# Execute Diffuse only when the two APKs are built successfully
diffuse:
needs: [ build-base, build-pr ]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Download APKs
uses: actions/download-artifact@v1
with:
name: apk
- name: diffuse
id: diffuse
uses: usefulness/diffuse-action@v1
with:
old-file-path: apk/identity-example-release-base.apk
new-file-path: apk/identity-example-release-pr.apk

# Post comment with output

- uses: peter-evans/find-comment@v1
id: find_comment
with:
issue-number: ${{ github.event.pull_request.number }}
body-includes: Diffuse output

- uses: peter-evans/create-or-update-comment@v1
if: ${{ steps.diffuse.outputs.diff-raw != null || steps.find_comment.outputs.comment-id != null }}
with:
body: |
Diffuse output:
${{ steps.diffuse.outputs.diff-gh-comment }}
edit-mode: replace
comment-id: ${{ steps.find_comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
token: ${{ secrets.GITHUB_TOKEN }}

- name: Upload diffuse output
uses: actions/upload-artifact@v2
with:
name: diffuse-output
path: ${{ steps.diffuse.outputs.diff-file }}

# Use emerge tools to analyze the example app size
apk-size-analysis:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Generate Android release bundle
run: ./gradlew :identity-example:bundleRelease
- name: Upload artifact to Emerge
uses: EmergeTools/[email protected]
with:
artifact_path: identity-example/build/outputs/bundle/theme1Release/identity-example-theme1-release.aab
emerge_api_key: ${{ secrets.EMERGE_API_KEY }}
build_type: release # Optional, change if your workflow builds a specific type
#name: identity-example size diff
#on:
# pull_request:
# paths:
# - 'identity/**'
# - 'stripe-core/**'
# - 'camera-core/**'
# - 'dependencies.gradle'
#jobs:
# # Checkout base branch and build the APK
# build-base:
# name: Build base
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# with:
# ref: ${{ github.base_ref }}
# - name: Build base branch
# run: ./gradlew :identity-example:assembleRelease && mv identity-example/build/outputs/apk/theme1/release/identity-example-theme1-release-unsigned.apk identity-example/build/outputs/apk/theme1/release/identity-example-release-base.apk
# - name: Upload APK
# uses: actions/upload-artifact@v1
# with:
# name: apk
# path: identity-example/build/outputs/apk/theme1/release/identity-example-release-base.apk
#
# # Checkout PR branch and build the APK
# build-pr:
# name: Build PR
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# - name: Build PR branch
# run: ./gradlew :identity-example:assembleRelease && mv identity-example/build/outputs/apk/theme1/release/identity-example-theme1-release-unsigned.apk identity-example/build/outputs/apk/theme1/release/identity-example-release-pr.apk
# - name: Upload APK
# uses: actions/upload-artifact@v1
# with:
# name: apk
# path: identity-example/build/outputs/apk/theme1/release/identity-example-release-pr.apk
#
# # Execute Diffuse only when the two APKs are built successfully
# diffuse:
# needs: [ build-base, build-pr ]
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
# - name: Download APKs
# uses: actions/download-artifact@v1
# with:
# name: apk
# - name: diffuse
# id: diffuse
# uses: usefulness/diffuse-action@v1
# with:
# old-file-path: apk/identity-example-release-base.apk
# new-file-path: apk/identity-example-release-pr.apk
#
# # Post comment with output
#
# - uses: peter-evans/find-comment@v1
# id: find_comment
# with:
# issue-number: ${{ github.event.pull_request.number }}
# body-includes: Diffuse output
#
# - uses: peter-evans/create-or-update-comment@v1
# if: ${{ steps.diffuse.outputs.diff-raw != null || steps.find_comment.outputs.comment-id != null }}
# with:
# body: |
# Diffuse output:
#
# ${{ steps.diffuse.outputs.diff-gh-comment }}
# edit-mode: replace
# comment-id: ${{ steps.find_comment.outputs.comment-id }}
# issue-number: ${{ github.event.pull_request.number }}
# token: ${{ secrets.GITHUB_TOKEN }}
#
# - name: Upload diffuse output
# uses: actions/upload-artifact@v2
# with:
# name: diffuse-output
# path: ${{ steps.diffuse.outputs.diff-file }}
#
# # Use emerge tools to analyze the example app size
# apk-size-analysis:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - name: Generate Android release bundle
# run: ./gradlew :identity-example:bundleRelease
# - name: Upload artifact to Emerge
# uses: EmergeTools/[email protected]
# with:
# artifact_path: identity-example/build/outputs/bundle/theme1Release/identity-example-theme1-release.aab
# emerge_api_key: ${{ secrets.EMERGE_API_KEY }}
# build_type: release # Optional, change if your workflow builds a specific type
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
sdk=30

2 changes: 2 additions & 0 deletions stripecardscan/src/test/resources/robolectric.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
sdk=30

2 changes: 2 additions & 0 deletions wechatpay/src/test/resources/robolectric.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
sdk=30

0 comments on commit bcf428b

Please sign in to comment.