[Not being merged to master] Add public api for primary button #4888

skyler-stripe · 2022-04-20T00:09:03Z

Summary

NOT BEING MERGED TO MASTER

Adds the rules api for primary button as described here: https://paper.dropbox.com/doc/2022-04-18-PaymentSheet-Primary-Button-Appearance-APIs-Mobile-API-Review--Bf9LmLV57JZ8iL4s5Jz3~1mkAg-vjjl5N5OxQ7ZAK8VEgkVD

Motivation

Adds more customization to payment sheet.
Will be merged to private beta branch

Testing

Added tests
Modified tests
Manually verified

default looks the same
just setting variables api will also set primary button
setting primary button changes the button differently from variables api values
original primaryButton api still works.

Screenshots

// no primarybutton showing that it follows the base level.
val appearance = PaymentSheet.Appearance(
    colorsLight = PaymentSheet.Colors.defaultLight.copy(
        primary = Color.RED
    ),
    shapes = PaymentSheet.Shapes.default.copy(
        borderStrokeWidthDp = 5.0f,
        cornerRadiusDp = 20.0f
    ),
    typography = PaymentSheet.Typography.default.copy(
        fontResId = R.font.cursive
    )
)

// simple background change
val appearance = PaymentSheet.Appearance(
    colorsLight = PaymentSheet.Colors.defaultLight.copy(
        primary = Color.RED
    ),
    primaryButton = PaymentSheet.PrimaryButton(
        colorsLight = PaymentSheet.PrimaryButtonColors.defaultLight.copy(
            background = Color.BLACK,
        )
    )
)

// primary button config that is different to show that it changes independently when set  
val appearance = PaymentSheet.Appearance(
    colorsLight = PaymentSheet.Colors.defaultLight.copy(
        primary = Color.RED
    ),
    shapes = PaymentSheet.Shapes.default.copy(
        cornerRadiusDp = 5.0f
    ),
    typography = PaymentSheet.Typography.default.copy(
        fontResId = null
    ),
    primaryButton = PaymentSheet.PrimaryButton(
        colorsLight = PaymentSheet.PrimaryButtonColors(
            background = Color.TRANSPARENT,
            onBackground = Color.BLACK,
            border = Color.BLACK,
        ),
        shape = PaymentSheet.PrimaryButtonShape(
            cornerRadiusDp = 0.0f,
        ),
        typography = PaymentSheet.PrimaryButtonTypography(
            fontResId = R.font.cursive
        )
    )
)

github-actions · 2022-04-20T00:18:14Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │  13.2 MiB │  13.2 MiB │ +10.9 KiB │  44.2 MiB │  44.2 MiB │ +16.4 KiB 
     arsc │   1.6 MiB │   1.6 MiB │  -1.9 KiB │   1.6 MiB │   1.6 MiB │  -1.9 KiB 
 manifest │   2.9 KiB │   2.9 KiB │       0 B │  12.3 KiB │  12.3 KiB │       0 B 
      res │ 692.1 KiB │ 675.1 KiB │ -16.9 KiB │   1.1 MiB │   1.1 MiB │ -36.5 KiB 
    asset │  79.4 KiB │  78.9 KiB │    -518 B │ 108.9 KiB │ 108.4 KiB │    -518 B 
    other │    80 KiB │    80 KiB │       0 B │ 154.9 KiB │ 154.9 KiB │       0 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │  15.6 MiB │  15.6 MiB │  -8.5 KiB │  47.1 MiB │  47.1 MiB │ -22.4 KiB 

         │          raw           │               unique               
         ├────────┬────────┬──────┼────────┬────────┬──────────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff             
─────────┼────────┼────────┼──────┼────────┼────────┼──────────────────
   files │      3 │      3 │    0 │        │        │                  
 strings │ 213296 │ 213328 │  +32 │ 188084 │ 188139 │  +55 (+174 -119) 
   types │  36851 │  36854 │   +3 │  34246 │  34265 │  +19 (+47 -28)   
 classes │  31671 │  31682 │  +11 │  31671 │  31682 │  +11 (+30 -19)   
 methods │ 189885 │ 190049 │ +164 │ 183952 │ 184124 │ +172 (+286 -114) 
  fields │ 130644 │ 130623 │  -21 │ 129808 │ 129783 │  -25 (+79 -104)  

 ARSC    │ old  │ new  │ diff         
─────────┼──────┼──────┼──────────────
 configs │  292 │  292 │   0          
 entries │ 5607 │ 5593 │ -14 (+0 -14)

APK

      compressed      │     uncompressed     │                               
──────────┬───────────┼──────────┬───────────┤                               
 size     │ diff      │ size     │ diff      │ path                          
──────────┼───────────┼──────────┼───────────┼───────────────────────────────
  3.6 MiB │ +17.8 KiB │ 10.2 MiB │ +45.1 KiB │ ∆ classes3.dex                
  3.2 MiB │    -7 KiB │  8.7 MiB │ -28.7 KiB │ ∆ classes2.dex                
          │  -2.7 KiB │          │  -6.5 KiB │ - res/Fv.xml                  
          │    -2 KiB │          │  -4.8 KiB │ - res/KT.xml                  
  1.6 MiB │  -1.9 KiB │  1.6 MiB │  -1.9 KiB │ ∆ resources.arsc              
          │  -1.7 KiB │          │  -4.5 KiB │ - res/sC.xml                  
          │  -1.3 KiB │          │  -2.8 KiB │ - res/74.xml                  
          │  -1.2 KiB │          │  -2.3 KiB │ - res/wW.xml                  
          │  -1.1 KiB │          │  -2.3 KiB │ - res/kY.xml                  
          │  -1.1 KiB │          │  -2.1 KiB │ - res/Hv.xml                  
          │  -1.1 KiB │          │  -2.2 KiB │ - res/dQ.xml                  
          │    -1 KiB │          │  -1.9 KiB │ - res/JN.xml                  
          │    -939 B │          │  -1.8 KiB │ - res/5K.xml                  
          │    -853 B │          │  -1.4 KiB │ - res/u4.xml                  
          │    -714 B │          │  -1.2 KiB │ - res/XN.xml                  
          │    -709 B │          │  -1.5 KiB │ - res/qu.xml                  
          │    -656 B │          │  -1.1 KiB │ - res/Sg.xml                  
    7 KiB │    -518 B │  6.9 KiB │    -518 B │ ∆ assets/dexopt/baseline.prof 
  6.5 MiB │      +2 B │ 25.3 MiB │       0 B │ ∆ classes.dex                 
    320 B │      -2 B │    464 B │       0 B │ ∆ res/9o.xml                  
    707 B │      +2 B │  1.3 KiB │       0 B │ ∆ res/CF.xml                  
    324 B │      +2 B │    464 B │       0 B │ ∆ res/uP.xml                  
    760 B │      +1 B │  1.7 KiB │       0 B │ ∆ res/4L.xml                  
    796 B │      +1 B │  1.6 KiB │       0 B │ ∆ res/LG.xml                  
    326 B │      -1 B │    464 B │       0 B │ ∆ res/U41.xml                 
  1.2 KiB │      +1 B │  3.5 KiB │       0 B │ ∆ res/_n.xml                  
    334 B │      +1 B │    400 B │       0 B │ ∆ res/kL.xml                  
──────────┼───────────┼──────────┼───────────┼───────────────────────────────
 14.8 MiB │  -8.5 KiB │ 45.8 MiB │ -22.4 KiB │ (total)

DEX

STRINGS:

   old    │ new    │ diff            
  ────────┼────────┼─────────────────
   188084 │ 188139 │ +55 (+174 -119) 
  + *
  ���
  ���
  ���
  ���
  ���
  ���
  
  ���
  ���
  ���
  ����� �2�����0�����0�0�:����B�¢����J�����0�2�����0�2��	��0�H�J��
  ��0�2�����02��
  ����0�H�¨��
  + ,
  ���
  ���
  
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  �7� �2�0�:����B���������0�������0�������0�¢����J��
  ��0�R�����0�X��¢��
  �����	R�����0�X��¢��
  ���
  ��R�����0�X��¢��
  ����	�����¨��
  + <
  ���
  ���
  
  ���
  ���
  ���
  ���
  ���
  
  ���
  
  ��
  ���
  ���
  
  ���
  �������2�0�B��������0�������0�������0�¢����J	�
  ��0�HÆ�J	����0�HÆ�J	����0�HÆ�J'����02�������0�2�������0�2�������0�HÆ�J	����0�HÖ�J�����0�2�������0�HÖ�J	����0�HÖ�J	����0�HÖ�J�����0�2�����0�2�����0�HÖ�R�����0�X��¢��
  �����	R�����0�X��¢��
  ���
  ��R�����0�X��¢��
  ����	¨��
  + \
  ���
  ���
  
  ���
  
  ���
  ���
  
  ���
  
  ���
  
  ���
  ���
  ���
  ���
  ���
  
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  �����2�0�:�!B5��������0����������0�0�������0����	��0
  ������0¢���
  J�����0�2�����0�H�J�����0�H�@ø�¢����J�����0�2�����0�H�@ø�¢����J�����0�2�����0�H�@ø�¢����J�����0�2�����0 R���������0�0�X��¢��
  R�����0�X��¢��
  R��	��0
  X��¢��
  R�����0�X��¢��
  R�����0X��¢��
  R���������0�0�¢��
  ���������
  ���¨�
  + _linkedAccountSessionId
  + (Lcom/stripe/android/connections/ConnectionsSheet;)V
  + (Lcom/stripe/android/payments/bankaccount/navigation/CollectBankAccountContract_Args;Lkotlinx/coroutines/flow/MutableSharedFlow;Lcom/stripe/android/payments/bankaccount/domain/CreateLinkAccountSession;Lcom/stripe/android/payments/bankaccount/domain/AttachLinkAccountSession;Lcom/stripe/android/core/Logger;)V
  + (Ljava/lang/String;Ljava/lang/String;Lcom/stripe/android/payments/bankaccount/CollectBankAccountConfiguration;)V
  + ConnectionsPaymentsProxy.kt
  + IsConnectionsAvailable.kt
  + Lcom/stripe/android/connections/ConnectionsSheet_Companion;
  + Lcom/stripe/android/connections/ConnectionsSheet_Configuration;
  + Lcom/stripe/android/connections/ConnectionsSheet;
  + Lcom/stripe/android/connections/ConnectionsSheetResult_Canceled;
  + Lcom/stripe/android/connections/ConnectionsSheetResult_Completed;
  + Lcom/stripe/android/connections/ConnectionsSheetResult_Failed;
  + Lcom/stripe/android/connections/ConnectionsSheetResult;
  + Lcom/stripe/android/connections/ConnectionsSheetResultCallback;
  + Lcom/stripe/android/connections/model/LinkAccountSession;
  + Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_Companion_create_1;
  + Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_Companion_create_2;
  + Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_Companion;
  + Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_sam_com_stripe_android_connections_ConnectionsSheetResultCallback_0;
  + Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy;
  + Lcom/stripe/android/payments/connections/DefaultConnectionsPaymentsProxy;
  + Lcom/stripe/android/payments/connections/UnsupportedConnectionsPaymentsProxy;
  + Lcom/stripe/android/payments/connections/reflection/DefaultIsConnectionsAvailable;
  + Lcom/stripe/android/payments/connections/reflection/IsConnectionsAvailable;
  + SMAP
  CollectBankAccountViewModel.kt
  Kotlin
  *S Kotlin
  *F
  + 1 CollectBankAccountViewModel.kt
  com/stripe/android/payments/bankaccount/ui/CollectBankAccountViewModel
  + 2 fake.kt
  kotlin/jvm/internal/FakeKt
  *L
  1#1,144:1
  1#2:145
  *E
  
  + SMAP
  CollectBankAccountViewModel.kt
  Kotlin
  *S Kotlin
  *F
  + 1 CollectBankAccountViewModel.kt
  com/stripe/android/payments/bankaccount/ui/CollectBankAccountViewModel_attachLinkAccountSessionToIntent_1
  + 2 fake.kt
  kotlin/jvm/internal/FakeKt
  *L
  1#1,144:1
  1#2:145
  *E
  
  + com.stripe.android.connections.ConnectionsSheet
  + connectionsPaymentsProxy
  + connectionsSheet
  + isConnectionsAvailable
  + onConnectionsResult(Lcom/stripe/android/connections/ConnectionsSheetResult;)V
  + onConnectionsSheetResult
  + �
  
  ���
  ���
  
  ���
  ����0�*�0�H�����0�*�0�H¨��
  + �
  ���
  ��
  ���
  ���
  �������2�0�B���¢����R�����0�¢��
  ������R�����0�¢��
  ������¨�	
  + (
  ���
  ��
  ���
  ���
  ���
  ���
  
  ���
  
  ���
  ������2�0�B�¢����J�����02����0�J�����02����0�J�����02�����0�J�����02�����0	J��
  ��02��
  ��0�R�����0�X��¢��
  R�����0�X��¢��
  R�����0�X��¢��
  R�����0	X��¢��
  R�
...✂

ARSC

ENTRIES:

   old  │ new  │ diff         
  ──────┼──────┼──────────────
   5607 │ 5593 │ -14 (+0 -14) 
  - drawable/stripe_ic_bank_boa
  - drawable/stripe_ic_bank_capitalone
  - drawable/stripe_ic_bank_citi
  - drawable/stripe_ic_bank_compass
  - drawable/stripe_ic_bank_morganchase
  - drawable/stripe_ic_bank_nfcu
  - drawable/stripe_ic_bank_pnc
  - drawable/stripe_ic_bank_stripe
  - drawable/stripe_ic_bank_suntrust
  - drawable/stripe_ic_bank_svb
  - drawable/stripe_ic_bank_td
  - drawable/stripe_ic_bank_usaa
  - drawable/stripe_ic_bank_usbank
  - drawable/stripe_ic_bank_wellsfargo

paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheet.kt

…ules

* Add public api for project wardrobe (not being merged to master) (#4760) * add public api for project wardrobe * attempt #2 * change from floats to TextUnits for default typography * forgot typography * api dump * [Not being merged to master] Add public api for primary button (#4888) * Add public api for primary button * apidump * add nullables to make construction easier * update docs * Create Appearance Playground (#4897) * add screenshot tests for apperance work (#4939) * add primary button rules to playground (#4935) * Add project wardrobe configs to init events (#4967) * Add project wardrobe configs to init events * shorten config field to save url size * Dogfood feedback for Appearance APIs (#4996) * address dogfooding comments * api dump

skyler-stripe added 2 commits April 19, 2022 15:45

Merge branch 'master' into payment_sheet_appearance_beta_1

bb9653e

Add public api for primary button

49c63da

skyler-stripe requested review from brnunes-stripe, michelleb-stripe and jameswoo-stripe as code owners April 20, 2022 00:09

skyler-stripe self-assigned this Apr 20, 2022

apidump

37a4072

skyler-stripe assigned brnunes-stripe, michelleb-stripe, jameswoo-stripe and skyler-stripe and unassigned skyler-stripe, brnunes-stripe, michelleb-stripe and jameswoo-stripe Apr 20, 2022

skyler-stripe changed the title ~~[Not being merged to master] Add public api for primary button~~ [Not being merged to master, WIP] Add public api for primary button Apr 20, 2022

skyler-stripe force-pushed the addPrimaryButtonRules branch 2 times, most recently from 9252188 to d811099 Compare April 20, 2022 17:47

add nullables to make construction easier

b0b94ad

skyler-stripe force-pushed the addPrimaryButtonRules branch from d811099 to b0b94ad Compare April 20, 2022 17:48

jameswoo-stripe reviewed Apr 20, 2022

View reviewed changes

paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheet.kt Show resolved Hide resolved

skyler-stripe changed the title ~~[Not being merged to master, WIP] Add public api for primary button~~ [Not being merged to master] Add public api for primary button Apr 20, 2022

skyler-stripe requested a review from jameswoo-stripe April 20, 2022 18:07

skyler-stripe assigned brnunes-stripe, michelleb-stripe and jameswoo-stripe and unassigned skyler-stripe Apr 20, 2022

jameswoo-stripe approved these changes Apr 20, 2022

View reviewed changes

stripe-ci unassigned jameswoo-stripe Apr 20, 2022

yuki-stripe reviewed Apr 20, 2022

View reviewed changes

update docs

f812e2c

skyler-stripe force-pushed the addPrimaryButtonRules branch from 47e4fba to f812e2c Compare April 20, 2022 19:15

skyler-stripe requested a review from yuki-stripe April 20, 2022 19:16

skyler-stripe force-pushed the payment_sheet_appearance_beta_1 branch from bb9653e to 2602a0d Compare April 21, 2022 00:17

Merge branch 'payment_sheet_appearance_beta_1' into addPrimaryButtonR…

cd0dad6

…ules

skyler-stripe merged commit 02a5819 into payment_sheet_appearance_beta_1 Apr 21, 2022

skyler-stripe deleted the addPrimaryButtonRules branch April 21, 2022 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Not being merged to master] Add public api for primary button #4888

[Not being merged to master] Add public api for primary button #4888

skyler-stripe commented Apr 20, 2022 •

edited

Loading

github-actions bot commented Apr 20, 2022 •

edited

Loading

[Not being merged to master] Add public api for primary button #4888

[Not being merged to master] Add public api for primary button #4888

Conversation

skyler-stripe commented Apr 20, 2022 • edited Loading

Summary

Motivation

Testing

Screenshots

github-actions bot commented Apr 20, 2022 • edited Loading

skyler-stripe commented Apr 20, 2022 •

edited

Loading

github-actions bot commented Apr 20, 2022 •

edited

Loading