Add public api for project wardrobe (not being merged to master) #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyler-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
jameswoo-stripe
as code owners
skyler-stripe
changed the title
|
Diffuse output: |
skyler-stripe
assigned skyler-stripe and unassigned brnunes-stripe, michelleb-stripe and jameswoo-stripe
skyler-stripe
force-pushed
the
appearenceApi
branch
from
d524451 to
1618a75
Compare
skyler-stripe
force-pushed
the
appearenceApi
branch
from
1618a75 to
bde4cb0
Compare
skyler-stripe
changed the title
skyler-stripe
assigned brnunes-stripe, michelleb-stripe and jameswoo-stripe and unassigned skyler-stripe
payments-ui-core/src/main/java/com/stripe/android/ui/core/PaymentsTheme.kt
Outdated
Show resolved
Hide resolved
payments-ui-core/src/main/java/com/stripe/android/ui/core/PaymentsTheme.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentOptionsActivity.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheet.kt
Outdated
Show resolved
Hide resolved
skyler-stripe
assigned skyler-stripe and unassigned brnunes-stripe, michelleb-stripe and jameswoo-stripe
skyler-stripe
changed the base branch from
master
to
payment_sheet_appearance_beta_1
skyler-stripe
changed the title
skyler-stripe
changed the title
skyler-stripe
assigned brnunes-stripe, michelleb-stripe and jameswoo-stripe and unassigned skyler-stripe
jameswoo-stripe
approved these changes
Apr 5, 2022
skyler-stripe
added a commit
that referenced
this pull request
May 17, 2022
* Add public api for project wardrobe (not being merged to master) (#4760) * add public api for project wardrobe * attempt #2 * change from floats to TextUnits for default typography * forgot typography * api dump * [Not being merged to master] Add public api for primary button (#4888) * Add public api for primary button * apidump * add nullables to make construction easier * update docs * Create Appearance Playground (#4897) * add screenshot tests for apperance work (#4939) * add primary button rules to playground (#4935) * Add project wardrobe configs to init events (#4967) * Add project wardrobe configs to init events * shorten config field to save url size * Dogfood feedback for Appearance APIs (#4996) * address dogfooding comments * api dump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note above that this will not be merged to the master branch. This is for the beta.
PaymentsThemeConfigtoPaymentsThemeDefaults, add all variables to data classes under it.PaymentsThemehave mutable variables.Motivation
A bit of explanation
So we have a few layers of colors, shapes, and typography. Because we have some variables that are not a part of the public appearance API we need to have two groups of variables. I wanted to lay out what each represent and why we need them.
PaymentsTheme.kt
PaymentsColors,PaymentsShapes, andPaymentsTypographyrepresent all of the styling we have, both public and internal.PaymentsThemeDefaultsholds all of the default values for all stylings we have, it is the single source of truth for all default colors, shapes, and typography.PaymentsComposeColorsandPaymentsComposeShapesmap the previously mentioned data classes toMaterialThemevalues along with functions to translate between the two.PaymentsThemeis analogous toMaterialThemein that it has a composable function version and singleton. This format allows us to match patterns and replaceMaterialThemePaymentSheet.kt
The new values in
Appearanceare the variables that we allow merchants to mutate. They all match 1 to 1 with a variable inside ofPaymentsThemeDefaultsbut not all variables are present because some we keep internal. This is an object we expect merchants to manipulate.Testing