Authorize OSM access not working #413

PanderMusubi · 2017-07-24T05:53:03Z

Authorize OSM access is not working in version 1.0 on LineageOS with GAPPS pico and F-Droid. I can choose to authorize via OsmAnd~, which doesn't work at all and results in a place in the middle of the ocean. Other way of authorization is via Firefox. That results in an error Unable to reach the authorization server. However, when I open Firefox manually, I see a tab opened for authorization. Logging in has no further effect on the app where I remain Not yet authorized.

Trying to downgrade to 0.13, to test that, resulted in an unknown error. De-installing 1.0 and installing 0.13 worked. There authorization works properly as it seems to be a different implementation.

The text was updated successfully, but these errors were encountered:

westnordost · 2017-07-24T09:46:48Z

Downgrading is not implemented, any downgrades that involve a different DB scheme will not work. To downgrade, you'd need to clear the data. The middle of the ocean bug is known, that's the current LOST (third party library). Can you be more specific when exactly the auth fails and ideally what is logged on console? What browser do you use? Did you try another browser? Do you use something other than the normal name+pw? (I.e. Google etc) Yes, v0 uses a WebView inside the app, v1 uses the external browser as it is recommended in the OAuth protocol and necessary when using Google login. Am 24. Juli 2017 07:53:05 MESZ schrieb Pander <[email protected]>:

…

Authorize OSM access is not working in version 1.0 on LineageOS with GAPPS pico and F-Droid. I can choose to authorize via OsmAnd~, which doesn't work at all and results in a place in the middle of the ocean. Other way of authorization is via Firefox. That results in an error `Unable to reach the authorization server`. However, when I open Firefox manually, I see a tab opened for authorization. Logging in has no further effect on the app where I remain `Not yet authorized`. Trying to downgrade to 0.13, to test that, resulted in an unknown error. De-installing 1.0 and installing 0.13 worked. There authorization works properly as it seems to be a different implementation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #413

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

westnordost · 2017-07-24T09:57:44Z

Also see #386
Similar problem or different problem?

PanderMusubi · 2017-07-24T15:35:50Z

Most probably the same issues as I see in the screen recording. Note that GAPPS pico is lacking the Android System WebView app, but installing that doesn't make a difference.

westnordost · 2017-07-24T15:58:27Z

You need to elaborate in the things I asked you because that issue was fixed. Am 24. Juli 2017 17:35:53 MESZ schrieb Pander <[email protected]>:

…

Most probably the same issues as I see in the screen recording. Note that GAPPS pico is lacking the Android System WebView app, but installing that doesn't make a difference. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #413 (comment)

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

PanderMusubi · 2017-07-24T16:20:35Z

"Can you be more specific when exactly the auth fails and ideally what is logged on console?" -> Which console?

"What browser do you use?" -> Firefox, latest stable from Google Play.

"Did you try another browser?" -> I installed Android System WebView app but didn't matters

"Do you use something other than the normal name+pw? (I.e. Google etc)" -> username + passwor, worked before with 0.13

does this answer your questions?

westnordost · 2017-07-24T17:53:02Z

Almost. I need to know when exactly the message comes: Before Firefox even opens or after you entered your credentials in Firefox on returning to the app?

Regarding the console: Would you do you me a favour and download a log reader like https://play.google.com/store/apps/details?id=com.nolanlawson.logcat&hl=en or similar, leave it running in the background while trying to authenticate and tell me what is being logged on the console from streetcomplete when the authorization fails?

PanderMusubi · 2017-07-24T18:59:38Z

Firefox never comes to the foreground. If I go to Firefox, I see the opened tabs. If I login, it does not return to StreetComplete. If I go to StreetComplete manually, I am not logged in. Plenty of combination of this results in not getting logged in.

Do you have an alternative log reader from F-Droid I could use as I prefer apps from there?

PanderMusubi · 2017-07-24T19:00:56Z

http://fdroid.org/packages/com.tortel.syslog/ or http://fdroid.org/packages/org.jtb.alogcat/ ?

westnordost · 2017-07-24T19:10:05Z

Any should do the job.

westnordost · 2017-07-24T19:12:34Z

Firefox never comes to the foreground. If I go to Firefox, I see the opened tabs.

Wow, this is weird. How can it be possible that any app opens another app "in the background"?? Can you close all those opened tabs please and try to reproduce it with a "fresh" Firefox? (No openstreetmap tabs opened). Is the behavior that a tab opened but Android did not switch from StreetComplete to Firefox reproducable?

krzyk · 2017-07-24T19:23:37Z

@PanderMusubi Maybe you have a tab queue enabled in Firefox (https://support.mozilla.org/en-US/kb/open-links-background-later-viewing-firefox-android)?

Is Firefox set as the default browser? (https://support.mozilla.org/en-US/kb/make-firefox-default-browser-android#w_android-6-marshmallow-and-higher)

jacopofar · 2017-07-24T20:53:26Z

Same problem here using Firefox on Android 7.1 and authenticating to OpenStreetMap using the Google account. I see the requested to authorize the application inside the browser, give it and the tab closes. Then Streetcomplete says there was a problem connecting to the server and can't login.

Subsequent requests to authenticate open the browser which closes immediately, as described above.

Can I help providing further informations? Really like the idea, hope use it soon

jacopofar · 2017-07-24T21:01:15Z

Ok, temporarily disabling the tab queue in Firefox I could log in.

westnordost · 2017-07-24T21:58:34Z

Oh man... a neverending story. I summarize:

OAuth standard says that it is best practice to use an external browser for authentication instead of a WebView (see Authentication should use external browser instead of embedded webview #265)
Google blocks OAuth login with WebViews - must always use external browser (see "Unable to reach the authorization server" when using google third party login #348 and Google developers blog) since April
I reimplement the OAuth process to use the external browser
Firefox launches the callback url in an unusual way that breaks the OAuth process in a browser (see authorize OSM access is not working after change to external browser #386), but there is a workaround
Firefox has a Feature (tab queue) that effectively breaks the OAuth process in a browser (this ticket)

Result: Login with OAuth is broken either way when using the Google Account and Firefox as a browser, no matter what.

Who is to blame? Google, for enforcing the use of an external browser.
If it is possible for a browser to fuck up the OAuth workflow that much on an smartphone, then the workflow should obviously not rely on the communication between the app and a browser... There is a difference between "Best practice" (mentioned in a draft) and obligation.

Anyway, I fear this problem cannot be solved, as described aboce.

westnordost · 2017-07-25T09:24:01Z

The stack trace is:

07-25 11:19:21.889 28143-28143/de.westnordost.streetcomplete E/OsmOAuthDialogFragment: Error during authorization
oauth.signpost.exception.OAuthNotAuthorizedException: Authorization failed (server replied with a 401). This can happen if the consumer key was not correct or the signatures did not match.
    at oauth.signpost.AbstractOAuthProvider.handleUnexpectedResponse(AbstractOAuthProvider.java:243)
    at oauth.signpost.AbstractOAuthProvider.retrieveToken(AbstractOAuthProvider.java:193)
    at oauth.signpost.AbstractOAuthProvider.retrieveAccessToken(AbstractOAuthProvider.java:108)
    at de.westnordost.streetcomplete.oauth.OsmOAuthDialogFragment$RetrieveAccessTokenTask.doInBackground(OsmOAuthDialogFragment.java:235)
    at de.westnordost.streetcomplete.oauth.OsmOAuthDialogFragment$RetrieveAccessTokenTask.doInBackground(OsmOAuthDialogFragment.java:231)
    at de.westnordost.streetcomplete.util.InlineAsyncTask.doInBackground(InlineAsyncTask.java:24)
    at de.westnordost.streetcomplete.util.InlineAsyncTask.doInBackground(InlineAsyncTask.java:11)
    at android.os.AsyncTask$2.call(AsyncTask.java:292)
    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
    at java.lang.Thread.run(Thread.java:818)

The tab queue feature immediately sends the user back to the app the user was coming from (calls onResume()) which in turn assumes that the authentication has been finished and tries to continue the authentication process by retrieving the access token.
Probably it is possible to detect at this point whether the user already did the authentication or not by looking at the verifier.

Implementation should:

detect that
show the loading-window while the app is waiting for the user to switch to Firefox to authenticate

PanderMusubi · 2017-07-25T09:27:38Z

Perhaps get some advice from Firefox as they might have some extra solutions of plans in the near future. More apps will have the same challenge. Depending on Android System WebView app could be a temporarily solution. Non-custom ROMs all have it.

PanderMusubi · 2017-07-26T13:42:44Z

Android has also another default system browser, which is used to sign into free wifi networks (not the WebViews), could you use that to do the authorization?

westnordost · 2017-07-26T16:47:16Z

The system browser has been removed (and replaced with Chrome) with newer Android versions, as far as I know.

PanderMusubi · 2017-07-26T17:02:11Z

On LineageOS, there is a browser for wifi login. perhaps you could detet if that is there, use, that, it not, use webview, if not, use default user browser (probably firefix/chromium)

westnordost · 2017-07-26T18:08:03Z

Turns out this was pretty easy to fix.

easyKL · 2017-08-06T06:37:52Z

neither Firefox nor OsmAnd~(2.6.3) were able to authorize StreetComplete.
Tried with Chrome (59) and it went smoothly ;)

westnordost · 2017-08-06T07:28:59Z

Version 1 or 1.1? (this has been fixed in 1.1)

easyKL · 2017-08-06T12:04:54Z

Yes, I've seen the Closed label for this issue. I just wanted to say what I did :))
Yes, I'm still in 1.0 (F-Droid here)
THX!!!

zorun · 2017-09-10T12:19:34Z

I still have an authorization issue on LineageOS, with SC version 1.3 from F-Droid.

It opens the LineageOS broswer (Jelly), I can login to OSM and authorize the app, but then instead of returning to SC, it redirects to my search engine with a search query streetcomplete://oauth?oauth....

So, either the LineageOS browser does not take into account the streetcomplete:// kind of URL, or there is something wrong with SC.

westnordost · 2017-09-10T12:27:51Z

That sound's like LineageOS's browser's fault.

If LineageOS browser does not call StreetComplete, then StreetComplete can not answer.

zorun · 2017-09-10T12:35:37Z

I tried with another simple browser (de.baumann.browser) and it worked, so you must be right.

Do you have any pointer to the method you use to communicate with the browser, so that I can report the bug against LineageOS?

ENT8R · 2018-10-03T21:43:41Z

I reported the issue at the issue tracker of LineageOS a long time ago and there is still no response: https://jira.lineageos.org/browse/BUGBASH-1393

Moini · 2018-10-03T21:58:01Z

I've updated the issue, telling them it's still present in 15.1.

singpolyma · 2019-09-02T02:43:41Z

I am getting exactly this error with latest firefox from play store or even when changing my default browser to chrome. Browser comes up, I log in to OSM, I authorize the app, and then I am taken back to the app but get this "Unable to reach the authorization server" error.

matkoniecz · 2019-09-02T06:27:54Z

What is your phone and Android version? Are you using Android or one of special versions like Firefox Focus/Firefox Preview etc?

singpolyma · 2019-09-06T00:47:28Z

What is your phone and Android version? Are you using Android or one of special versions like Firefox Focus/Firefox Preview etc?

Android: 7.7.1 Phone: Nokia 2 Model: TA-1035 Browser: Latest Firefox from Google Play (but I also tried with Chrome and got the same result). One thing: my phone has *very* little RAM, so usually switching apps and switching back causes the first app to reload. Maybe some state is not being saved when Android OOMs the app after opening the browser?

matkoniecz · 2019-09-06T02:43:14Z

That would make sense and would be sadly probably unfixable (or to be more exact - not fixable in way that is reasonable to implement).

singpolyma · 2019-09-09T00:11:15Z

@matkoniecz really? I thought Android basically assumed any app could be "killed" at any time and everything is meant to be persisted temporarily to avoid this?

In any case -- can you think of any workaround I could maybe try to keep the app "open" long enough to complete the login?

matkoniecz · 2019-09-09T05:45:10Z

I may be wrong and there may be way too fix it. Opening a new issue may be a good idea (not sure whatever the author of the app noticed this discussion in a closed issue).

I may be wrong but I think that browser + StreetComplete In this situation is de facto a single app during this operation - with bigger resource requirements.

westnordost · 2019-09-09T07:09:46Z

I noticed it now

mimi89999 · 2020-01-19T13:13:54Z

I cannot authorize StreetComplete on LineageOS 17 (Android 10). When clicking authorize, my default browser (Firefox preview) opens, I am asked to connect to my OSM account, then I grant access to StreetComplete and then nothing happens. When I return to StreetComplete I see the loading message.

westnordost · 2020-01-19T14:33:05Z

This is likely an issue with "Firefox preview". (What is Firefox Preview?)

Though, perhaps I should revert to the old solution - using a WebView within the app. no external dependency on a browser necessary.

mimi89999 · 2020-01-19T15:26:32Z

That's Firefox preview: https://play.google.com/store/apps/details?id=org.mozilla.fenix

PanderMusubi · 2020-01-19T18:23:13Z

@mimi89999 can you test it with https://f-droid.org/en/packages/org.mozilla.fennec_fdroid/ ?

mimi89999 · 2020-01-19T23:09:32Z

I can confirm that it works fine with Fennec F-Droid

photoangell · 2020-02-17T17:13:23Z

I'm getting this on stock Android 8.1.0 with chrome installed. I had previously attempted with firefox, bromite, etc. and reinstalled Chrome to test this but no luck

photoangell · 2020-02-22T10:05:41Z

tried with Fennec as well, still getting the error
I can see loads of auth tokens in my osm account, it's just the response being passed back is not being handled somehow....

photoangell · 2020-02-22T11:37:28Z

ok. managed to solve it. downloaded release 0.13 (which uses a different auth method), authorised and then downloaded latest version.

okias · 2020-03-06T16:44:58Z

I can confirm with 16.1 - 17.3 that auth doesn't work with Firefox Fenix (Preview) and integrated browser. In both scenarios I get "Unknown protocol"

okias · 2020-03-14T21:13:43Z

still broken 👎 (version 18.0)

westnordost · 2020-03-14T22:48:29Z

It is fixed in the development branch and will be released for the next major

okias · 2020-03-14T23:23:46Z

It is fixed in the development branch and will be released for the next major

Thank you! For next time, you can use tag to mark this commit by

Fixes: #413

which will link fix with bug and also appears in bug, so people will instantly know it's fixed and bug closes itself :)

okias · 2020-04-06T22:14:15Z

I'd like to start contributing, any sign of alpha/beta release? @westnordost

westnordost · 2020-04-07T08:48:06Z

No, will still take time. Just use Firefox or Chrome to login

…

On 7 April 2020 00:14:29 CEST, David Heidelberg ***@***.***> wrote: I'd like to start contributing, any sign of alpha/beta release? @westnordost

okias · 2020-04-13T17:09:49Z

it accept my authorization, but then it re-ask after every change. And nothing gets pushed onto osm servers. I'll probably need this fix.

westnordost added bug feedback required more info is needed, issue will be likely closed if it is not provided labels Jul 24, 2017

westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Jul 25, 2017

westnordost closed this as completed in 813fbec Jul 26, 2017

HolgerJeromin mentioned this issue Jan 9, 2019

Authentication should use external browser instead of embedded webview MarcusWolschon/osmeditor4android#840

Closed

westnordost reopened this Sep 9, 2019

westnordost added this to the stats screen milestone Jan 24, 2020

westnordost mentioned this issue Mar 9, 2020

OSM login fails with stock browser in Sailfish OS #1760

Closed

westnordost closed this as completed Mar 13, 2020

westnordost mentioned this issue Dec 28, 2023

Google Play review unreasonably requires declaration of personal data collection - email address for OSM Login organicmaps/organicmaps#7000

Closed

Authorize OSM access not working #413

Authorize OSM access not working #413

Comments

PanderMusubi commented Jul 24, 2017

westnordost commented Jul 24, 2017 via email

westnordost commented Jul 24, 2017

PanderMusubi commented Jul 24, 2017

westnordost commented Jul 24, 2017 via email

PanderMusubi commented Jul 24, 2017

westnordost commented Jul 24, 2017

PanderMusubi commented Jul 24, 2017

PanderMusubi commented Jul 24, 2017

westnordost commented Jul 24, 2017

westnordost commented Jul 24, 2017

krzyk commented Jul 24, 2017

jacopofar commented Jul 24, 2017

jacopofar commented Jul 24, 2017

westnordost commented Jul 24, 2017 • edited Loading

westnordost commented Jul 25, 2017

PanderMusubi commented Jul 25, 2017 • edited Loading

PanderMusubi commented Jul 26, 2017

westnordost commented Jul 26, 2017

PanderMusubi commented Jul 26, 2017

westnordost commented Jul 26, 2017

easyKL commented Aug 6, 2017

westnordost commented Aug 6, 2017

easyKL commented Aug 6, 2017

zorun commented Sep 10, 2017

westnordost commented Sep 10, 2017 • edited Loading

zorun commented Sep 10, 2017

ENT8R commented Oct 3, 2018

Moini commented Oct 3, 2018

singpolyma commented Sep 2, 2019

matkoniecz commented Sep 2, 2019

singpolyma commented Sep 6, 2019 via email

matkoniecz commented Sep 6, 2019

singpolyma commented Sep 9, 2019

matkoniecz commented Sep 9, 2019

westnordost commented Sep 9, 2019

mimi89999 commented Jan 19, 2020

westnordost commented Jan 19, 2020 • edited Loading

mimi89999 commented Jan 19, 2020

PanderMusubi commented Jan 19, 2020

mimi89999 commented Jan 19, 2020

photoangell commented Feb 17, 2020

photoangell commented Feb 22, 2020 • edited Loading

photoangell commented Feb 22, 2020

okias commented Mar 6, 2020

okias commented Mar 14, 2020 • edited Loading

westnordost commented Mar 14, 2020

okias commented Mar 14, 2020

okias commented Apr 6, 2020

westnordost commented Apr 7, 2020 via email

okias commented Apr 13, 2020 • edited Loading

westnordost commented Jul 24, 2017 •

edited

Loading

PanderMusubi commented Jul 25, 2017 •

edited

Loading

westnordost commented Sep 10, 2017 •

edited

Loading

westnordost commented Jan 19, 2020 •

edited

Loading

photoangell commented Feb 22, 2020 •

edited

Loading

okias commented Mar 14, 2020 •

edited

Loading

okias commented Apr 13, 2020 •

edited

Loading