Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication should use external browser instead of embedded webview #265

Closed
mormegil-cz opened this issue May 26, 2017 · 3 comments
Closed
Assignees

Comments

@mormegil-cz
Copy link

See OAuth 2.0 for Native Apps (draft). The best practice for OAuth in native mobile apps is to open the (default external) browser, not to embed the authentication flow in a webview inside the app.

@HolgerJeromin
Copy link
Contributor

Yes.
My default browser is already authenticated on osm.org.
Furthermore i am sure that the website to enter my passwords is really the correct one (if i trust my default browser).
Streetcomplete could present my a fishing site in the web view.

@westnordost
Copy link
Member

I would accept a pull request that implements this but I am not planning to implement this myself.

@westnordost
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants