[module/vpc] Allow for finer grained VPC configuration #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Motivation
Our VPC module is quite opinionated. In particular, only a
/16CIDR is valid for the VPC configuration, using anything else would throw a validation error. Also, the binary math was static in computing the generated subnets, so if you were able to create a/20VPC, the corresponding subnets would use a/28prefix.Modifications
Added a new input variable called
subnet_newbits. Using this, you can specify the number of bits to add to the base CIDR to use for the subnets. So if you are using a/20, settingsubnet_newbits = 4will generate the subnets with a/24prefix.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc