Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vpc icdr validation to support more needs #64

Closed
wants to merge 1 commit into from

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Apr 26, 2022

Fixes #63

Motivation

The VPC CIDR validation limits user's requirements.

Modifications

Remove the cidr limits. So that user can specify vpc cidr from 10.x.x.x/0 to 10.x.x.x/32.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@maxsxu maxsxu requested a review from a team as a code owner April 26, 2022 08:09
@maxsxu maxsxu self-assigned this Apr 26, 2022
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Apr 26, 2022
@maxsxu maxsxu requested a review from jrsdav April 26, 2022 08:11
@maxsxu
Copy link
Member Author

maxsxu commented Apr 28, 2022

I'm going to close this PR as there is now a better solution. See #65

@maxsxu maxsxu closed this Apr 28, 2022
@maxsxu maxsxu deleted the max/remove-vpc-cidr-validation branch May 2, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove VPC CIDR validation in vpc module
1 participant