Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): allow higher term shard deleting #559

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Nov 4, 2024

Motivation

The coordinator will replace the ensemble when swapping the node. Therefore, the old node can't receive new term requests, and the actual shard term will be greater than the old server. and then the old server will keep printing

Invalid term when deleting shard

Modification

  • Allow higher term shard deleting.

Alternatives

  • save the deleting term before the new ensemble is elected.

@merlimat merlimat merged commit be8cef5 into main Nov 5, 2024
7 checks passed
@merlimat merlimat deleted the fix.shard.delete branch November 5, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants