fix lint

coordinator/impl/coordinator_e2e_test.go

@@ -805,10 +805,10 @@ func TestCoordinator_RefreshServerInfo(t *testing.T) {
 	}, 10*time.Second, 10*time.Millisecond)
 
 	// change the localhost to 127.0.0.1
-	var clusterServer []model.ServerAddress
+	clusterServer := make([]model.ServerAddress, 0)
 	for _, sv := range clusterConfig.Servers {
 		clusterServer = append(clusterServer, model.ServerAddress{
-			Public:   strings.Replace(sv.Public, "localhost", "127.0.0.1", -1),
+			Public:   strings.ReplaceAll(sv.Public, "localhost", "127.0.0.1"),
 			Internal: sv.Internal,
 		})
 	}

oxia/options_list.go

@@ -47,7 +47,7 @@ func (u *useIndex) applyRangeScan(opts *rangeScanOptions) {
 }
 
 // UseIndex let the users specify a different index to follow for the
-// Note: The returned list will contain they primary keys of the records
+// Note: The returned list will contain they primary keys of the records.
 func UseIndex(indexName string) ListOption {
 	return &useIndex{indexName}
 }

oxia/sync_client_impl_test.go

@@ -17,11 +17,12 @@ package oxia
 import (
 	"context"
 	"fmt"
-	"github.com/streamnative/oxia/server"
 	"log/slog"
 	"strings"
 	"testing"
 
+	"github.com/streamnative/oxia/server"
+
 	"github.com/stretchr/testify/assert"
 )
 

server/kv/db_test.go

@@ -16,11 +16,12 @@ package kv
 
 import (
 	"fmt"
-	"github.com/google/uuid"
 	"os"
 	"path"
 	"testing"
 
+	"github.com/google/uuid"
+
 	"github.com/stretchr/testify/assert"
 	pb "google.golang.org/protobuf/proto"
 

server/kv/kv_pebble.go

@@ -16,14 +16,15 @@ package kv
 
 import (
 	"fmt"
-	"golang.org/x/net/context"
 	"io"
 	"log/slog"
 	"os"
 	"path/filepath"
 	"sync/atomic"
 	"time"
 
+	"golang.org/x/net/context"
+
 	"github.com/cockroachdb/pebble/bloom"
 
 	"github.com/streamnative/oxia/common/compare"

server/wal/codec/codec.go

@@ -117,7 +117,7 @@ type Codec interface {
 	//   - buf: the byte slice containing the raw data.
 	//   - startFileOffset: the starting file offset from which recovery begins.
 	//   - baseEntryOffset: the base offset for the index entries, used to adjust entry offsets.
-	//   - commitOffset: a pointer to the commit offset, which is using for auto-discard uncommited corruption data
+	//   - commitOffset: a pointer to the commit offset, which is using for auto-discard uncommitted corruption data
 	//
 	// Returns:
 	//   - index: the recovered index data as a byte slice.
@@ -165,7 +165,7 @@ func ReadInt(b []byte, offset uint32) uint32 {
 	return binary.BigEndian.Uint32(b[offset : offset+4])
 }
 
-// Index buf
+// Index buf.
 var bufferPool = sync.Pool{}
 
 const initialIndexBufferCapacity = 16 * 1024

server/wal/codec/v1.go

@@ -16,10 +16,11 @@ package codec
 
 import (
 	"encoding/binary"
-	"github.com/pkg/errors"
-	"go.uber.org/multierr"
 	"io"
 	"os"
+
+	"github.com/pkg/errors"
+	"go.uber.org/multierr"
 )
 
 // Txn File:
@@ -33,7 +34,7 @@ import (
 // +----------------+----------------+----------------+
 // | Index(4 Bytes) | Index(4 Bytes) | 	... 		  |
 // +----------------+----------------+----------------+
-// Index: 			The file offset index
+// Index: 			The file offset index.
 var _ Codec = &V1{}
 
 const v1PayloadSizeLen uint32 = 4

server/wal/codec/v1_test.go

@@ -16,11 +16,12 @@ package codec
 
 import (
 	"encoding/binary"
-	"github.com/google/uuid"
 	"os"
 	"path"
 	"testing"
 
+	"github.com/google/uuid"
+
 	"github.com/stretchr/testify/assert"
 )
 

server/wal/codec/v2.go

@@ -16,11 +16,12 @@ package codec
 
 import (
 	"encoding/binary"
-	"go.uber.org/multierr"
 	"io"
 	"log/slog"
 	"os"
 
+	"go.uber.org/multierr"
+
 	"github.com/pkg/errors"
 
 	"github.com/streamnative/oxia/server/util/crc"
@@ -40,7 +41,7 @@ import (
 // | CRC(4Bytes)  | Index(4B) | Index(4B) | ... |
 // +--------------+-----------+-----------+-----+
 // CRC: 	 		32bit hash computed over the payload using CRC.
-// Index:    		The file offset index
+// Index:    		The file offset index.
 var _ Codec = &V2{}
 
 const v2PayloadSizeLen uint32 = 4
@@ -217,8 +218,8 @@ func (v *V2) RecoverIndex(buf []byte, startFileOffset uint32, baseEntryOffset in
 			// data corruption
 			if errors.Is(err, ErrOffsetOutOfBounds) || errors.Is(err, ErrDataCorrupted) {
 				if commitOffset != nil && currentEntryOffset > *commitOffset {
-					// uncommited data corruption, simply discard it
-					slog.Warn("discard the corrupted uncommited data.",
+					// uncommitted data corruption, simply discard it
+					slog.Warn("discard the corrupted uncommitted data.",
 						slog.Int64("entryId", currentEntryOffset), slog.Any("error", err))
 					break
 				}

server/wal/codec/v2_test.go

@@ -16,11 +16,12 @@ package codec
 
 import (
 	"encoding/binary"
-	"github.com/google/uuid"
 	"os"
 	"path"
 	"testing"
 
+	"github.com/google/uuid"
+
 	"github.com/stretchr/testify/assert"
 
 	"github.com/streamnative/oxia/server/util/crc"

server/wal/wal_ro_segment.go

@@ -329,7 +329,7 @@ func (r *readOnlySegmentsGroup) PollHighestSegment() (common.RefCount[ReadOnlySe
 	defer r.Unlock()
 
 	if r.allSegments.Empty() {
-		return nil, nil // nolint: nilnil
+		return nil, nil //nolint: nilnil
 	}
 
 	offset, _ := r.allSegments.Max()

server/wal/wal_ro_segment_test.go

@@ -16,10 +16,11 @@ package wal
 
 import (
 	"fmt"
-	"github.com/google/uuid"
 	"os"
 	"testing"
 
+	"github.com/google/uuid"
+
 	"github.com/streamnative/oxia/server/wal/codec"
 
 	"github.com/stretchr/testify/assert"

server/wal/wal_rw_segment_test.go

@@ -16,9 +16,10 @@ package wal
 
 import (
 	"encoding/binary"
-	"github.com/streamnative/oxia/server/wal/codec"
 	"testing"
 
+	"github.com/streamnative/oxia/server/wal/codec"
+
 	"github.com/stretchr/testify/assert"
 )