ethdb/pebble: cap memory table size as maxMemTableSize-1 (ethereum#28444

) (ethereum#2120)
streamingfast · Jan 3, 2024 · a25a214 · a25a214
1 parent 7c8fa2b
commit a25a214
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/ethdb/pebble/pebble.go b/ethdb/pebble/pebble.go
@@ -156,8 +156,15 @@ func New(file string, cache int, handles int, namespace string, readonly bool) (
 	// including a frozen memory table and another live one.
 	memTableLimit := 2
 	memTableSize := cache * 1024 * 1024 / 2 / memTableLimit
-	if memTableSize > maxMemTableSize {
-		memTableSize = maxMemTableSize
+
+	// The memory table size is currently capped at maxMemTableSize-1 due to a
+	// known bug in the pebble where maxMemTableSize is not recognized as a
+	// valid size.
+	//
+	// TODO use the maxMemTableSize as the maximum table size once the issue
+	// in pebble is fixed.
+	if memTableSize >= maxMemTableSize {
+		memTableSize = maxMemTableSize - 1
 	}
 
 	logger.Info("Allocated cache and file handles", "cache", common.StorageSize(cache*1024*1024),