Update opentelemetry dependency #1169
Conversation
|
Thanks for adding the Here's a preview of the changelog: This release adds support for the latest version of the optional opentelemetry dependency. Here's the preview release card for twitter: Here's the tweet text: |
| @@ -76,7 +76,7 @@ async def resolve(self, _next, root, info, *args, **kwargs): | |||
|
|
|||
| return result | |||
|
|
|||
| with self._tracer.use_span(self._root_span): | |||
| with trace.use_span(self._root_span): | |||
There was a problem hiding this comment.
Looks like it got moved in open-telemetry/opentelemetry-python#1668 🤷
There was a problem hiding this comment.
gotcha! thanks for explaing! 😊
pyproject.toml
Outdated
| opentelemetry-api = "^0.17b0" | ||
| opentelemetry-sdk = "^0.17b0" | ||
| opentelemetry-api = "^1.4.1" | ||
| opentelemetry-sdk = "^1.4.1" |
There was a problem hiding this comment.
I guess this might be an annoying upgrade for anyone who is using opentelemetry==0.17b0?
There was a problem hiding this comment.
it could be, maybe we can handle both versions? we only have two places where we had to change our code, so maybe we can do it
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 97.53% 97.44% -0.09%
==========================================
Files 87 87
Lines 3286 3291 +5
Branches 472 473 +1
==========================================
+ Hits 3205 3207 +2
- Misses 44 46 +2
- Partials 37 38 +1 |
Something like this? I'm not sure how to specify the version to allow the |
mhm, we could allow any version before 2? |
I think that still installs |
|
@joefreeman sounds good to me 😊 thanks! |
Description
This updates the (optional)
opentelemetrydependency from0.17b0to1.4.1.Types of Changes
Checklist