Move usespan out of tracer #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
move-usespan-out-of-tracer
branch
3 times, most recently
from
9edc084 to
ee1d970
Compare
owais
force-pushed
the
move-usespan-out-of-tracer
branch
from
ee1d970 to
f921966
Compare
owais
requested review from
a team,
aabmass and
ocelotl
and removed request for
a team
owais
force-pushed
the
move-usespan-out-of-tracer
branch
from
f921966 to
510dbd2
Compare
11 tasks
owais
force-pushed
the
move-usespan-out-of-tracer
branch
7 times, most recently
from
43d9d85 to
61f067a
Compare
lzchen
reviewed
Mar 5, 2021
| @@ -13,7 +13,7 @@ | |||
| # limitations under the License. | |||
| from typing import Optional | |||
|
|
|||
| from opentelemetry.context import get_value, set_value | |||
| from opentelemetry.context import attach, get_value, set_value | |||
There was a problem hiding this comment.
I think it got added as I first thought of placing the function here but also exporting it from trace module. Not sure why pylint/isort didn't catch this as an unused import. 🤔
Fixed now.
lzchen
approved these changes
Mar 5, 2021
owais
force-pushed
the
move-usespan-out-of-tracer
branch
from
61f067a to
6983d75
Compare
ocelotl
approved these changes
Mar 5, 2021
owais
force-pushed
the
move-usespan-out-of-tracer
branch
from
8e1fd87 to
64b1384
Compare
owais
force-pushed
the
move-usespan-out-of-tracer
branch
from
64b1384 to
5546950
Compare
codeboten
approved these changes
Mar 6, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1630
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
opentelemetry-api/oropentelemetry-sdk/Result of: #1630
Checklist: