Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle missing files #36

Merged
merged 16 commits into from
Oct 23, 2024
Merged

Better handle missing files #36

merged 16 commits into from
Oct 23, 2024

Conversation

verovaleros
Copy link
Member

Description

Fixes #30

This PR introduces checks to validate the following files exists:

  • honeypots_public_ips.csv: this file must exist, now raising an error if it's missing.
  • do_not_block_these_ips.csv: this file can or cannot exist, now continuing with an empty data frame.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested with both files missing
  • Tested with honeypot public ips missing and do not block these ips present
  • Tested with do not block these ips missing and honeypot public ips present
  • Tested with both files present

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@verovaleros verovaleros added bug Something isn't working enhancement New feature or request labels Oct 23, 2024
@verovaleros verovaleros added this to the v3.0.0 milestone Oct 23, 2024
@verovaleros verovaleros self-assigned this Oct 23, 2024
@verovaleros verovaleros merged commit b69b09f into development Oct 23, 2024
@verovaleros verovaleros deleted the aip-updates branch October 23, 2024 08:31
@verovaleros verovaleros mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] AIP cannot execute if do_not_block_these_ips.csv file does not exist, but file can be empty
1 participant