Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AIP cannot execute if do_not_block_these_ips.csv file does not exist, but file can be empty #30

Closed
verovaleros opened this issue Aug 2, 2023 · 0 comments · Fixed by #36
Assignees
Labels
bug Something isn't working
Milestone

Comments

@verovaleros
Copy link
Member

Describe the bug

If this file can be empty, it seems unnecessary that the existence of the file should be a strict requirement:

self.donotblocklist = pd.read_csv(path.join(data_dir, 'external', 'do_not_block_these_ips.csv'))

To Reproduce
Run AIP without this file:

docker run --rm -v /opt/zeek/logs/:/home/aip/AIP/data/raw:ro -v ${PWD}/data/:/home/aip/AIP/data/:rw --name aip stratosphereips/aip:latest bin/aip

Expected behaviour
If the file doesn't exist, then maybe it is possible to consider it empty. It would technically mean the same.

Screenshots
image

@verovaleros verovaleros added the bug Something isn't working label Aug 2, 2023
@verovaleros verovaleros moved this to 🆕 New in Stratosphere AIP Aug 2, 2023
@verovaleros verovaleros self-assigned this Oct 22, 2024
@verovaleros verovaleros moved this from 🆕 New to 🏗 In progress in Stratosphere AIP Oct 22, 2024
@verovaleros verovaleros added this to the v3.0.0 milestone Oct 22, 2024
@verovaleros verovaleros linked a pull request Oct 23, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Stratosphere AIP Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant