Add missing dependencies #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #187 +/- ##
=======================================
Coverage 76.53% 76.53%
=======================================
Files 11 11
Lines 179 179
Branches 37 37
=======================================
Hits 137 137
Misses 42 42 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shilman
approved these changes
Sep 5, 2022
Merged
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing an experiment to remove some unused dependencies from core Storybook packages, and found that some of the Vite sandboxes started to fail when the test-runner was run, due to missing
@babel/dependencies. Then I noticed that test-runner doesn't actually depend on them correctly. It's using babel to perform transforms, so I think it should include them independenciesnotdevDependencies.I also ran
npx depcheckand located a few other deps that the test-runner is relying on, but isn't specifying directly, so I added those as well.Version
Published prerelease version:
v0.7.1-next.0Changelog
🐛 Bug Fix
Authors: 1