Chore: Remove unused dependencies in /lib #19100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vite is failing in sandbox tests, because it is missing @babel/preset-react. Which is interesting, because it shouldn't need that, and the sandbox works fine for me locally. I think a .babelrc is being injected or something, when it shouldn't be. Still investigating. Edit: I figured out that |
This caused build to fail.
They use a sneaky alias resolution that isn't `cmd+f` findable.
# Conflicts: # code/lib/addons/package.json # code/lib/blocks/package.json # code/lib/client-api/package.json # code/lib/core-client/package.json # code/lib/core-common/package.json # code/lib/preview-web/package.json # code/lib/source-loader/package.json # code/yarn.lock
This should be removed once 7.1 stable is released
IanVS
changed the title
IanVS
requested review from
shilman and
ndelangen
and removed request for
shilman
ndelangen
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: There are dependencies that are being installed along with storybook that aren't being used.
What I did
I used
npx depcheckto help identify unused (and missing) dependencies, searched the repo for usages of those dependencies to be sure the tool wasn't giving wrong results, and removed deps or added deps when needed.This PR covers packages in
/lib, and I'll open other PRs to deal with addons and renderers, etc.Note: I also pinned the
@storybook/test-runnertonext, in order to pull in a change that is needed now that some babel dependencies are not always being installed. This can be reverted once @storybook/test-runner 0.7.1 is released.How to test
I think CI should be good enough to detect any bugs this might introduce.