Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook/angular): add default value to the budgets property #9207

Merged
merged 1 commit into from
Dec 22, 2019
Merged

fix(storybook/angular): add default value to the budgets property #9207

merged 1 commit into from
Dec 22, 2019

Conversation

nickbullock
Copy link
Contributor

@nickbullock nickbullock commented Dec 20, 2019 •
edited
Loading

Issue: Closes #9206

What I did

Added default value to the budgets property.

How to test

  • Is this testable with Jest or Chromatic screenshots? -Yes
  • Does this need a new example in the kitchen sink apps? -No
  • Does this need an update to the documentation? -No

@vercel
Copy link

vercel bot commented Dec 20, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/npn6ektbh
🌍 Preview: https://monorepo-git-fork-nickbullock-next.storybook.now.sh

@shilman
Copy link
Member

shilman commented Dec 21, 2019 •
edited
Loading

Thanks @nickbullock!!! @kroeder look ok to you?

@ndelangen
Copy link
Member

I'm guessing this will go in 6.0.0?

@shilman
Copy link
Member

shilman commented Dec 22, 2019 •
edited
Loading

@ndelangen I'd be happy to put it in 5.3 since it's a bug and the fix looks pretty harmless

@ndelangen ndelangen added this to the 5.3.0 milestone Dec 22, 2019
@ndelangen ndelangen merged commit a81130a into storybookjs:next Dec 22, 2019
@shilman shilman mentioned this pull request Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
angular bug
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

[Angular] storybook rc0 + ng9 rc7 error - failed to get angular-cli webpack config
3 participants
@nickbullock @shilman @ndelangen