Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] storybook rc0 + ng9 rc7 error - failed to get angular-cli webpack config #9206

Closed
nickbullock opened this issue Dec 20, 2019 · 1 comment · Fixed by #9207
Closed

Comments

@nickbullock
Copy link
Contributor

Describe the bug
There is a problem with next angular and storybook versions - can't load angular-cli webpack config.
I found out that budgets property in angular.json is the root of evil.
Workaround is to set some array value - "budgets": [] for example to project.architect.build.options.
Also created a github repo to reproduce

To Reproduce
Steps to reproduce the behavior:

  1. npm install -g @angular/cli@next && npm install -g @storybook/cli@next
  2. ng new app && cd app
  3. sb init
  4. npm run storybook
  5. see error

Expected behavior
Expected to load angular-cli webpack config, not storybook webpack config

Screenshots
Снимок экрана 2019-12-20 в 13 37 56

System:
sb info

Environment Info:

  System:
    OS: macOS 10.15.2
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 12.13.1 - /usr/local/bin/node
    npm: 6.13.4 - /usr/local/bin/npm
  Browsers:
    Chrome: 79.0.3945.88
    Safari: 13.0.4
  npmPackages:
    @storybook/addon-actions: ^5.3.0-rc.0 => 5.3.0-rc.0 
    @storybook/addon-links: ^5.3.0-rc.0 => 5.3.0-rc.0 
    @storybook/addon-notes: ^5.3.0-rc.0 => 5.3.0-rc.0 
    @storybook/addons: ^5.3.0-rc.0 => 5.3.0-rc.0 
    @storybook/angular: ^5.3.0-rc.0 => 5.3.0-rc.0 
  npmGlobalPackages:
    @storybook/cli: 5.2.8

ng --version

Angular CLI: 9.0.0-rc.7
Node: 12.13.1
OS: darwin x64

Angular: 9.0.0-rc.7
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-rc.7
@angular-devkit/build-angular     0.900.0-rc.7
@angular-devkit/build-optimizer   0.900.0-rc.7
@angular-devkit/build-webpack     0.900.0-rc.7
@angular-devkit/core              9.0.0-rc.7
@angular-devkit/schematics        9.0.0-rc.7
@ngtools/webpack                  9.0.0-rc.7
@schematics/angular               9.0.0-rc.7
@schematics/update                0.900.0-rc.7
rxjs                              6.5.3
typescript                        3.6.4
webpack                           4.41.2
@shilman
Copy link
Member

shilman commented Dec 23, 2019

Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-rc.1 containing PR #9207 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants