Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change viewport styling to more closely match v4 #8486

Merged
merged 5 commits into from
Jan 15, 2020
Merged

Change viewport styling to more closely match v4 #8486

merged 5 commits into from
Jan 15, 2020

Conversation

connor-baer
Copy link
Contributor

@connor-baer connor-baer commented Oct 20, 2019 •
edited
Loading

Issue: #5965

What I did

A regression in #7385 re-added the subjectively ugly black border that had been removed in #5979 to address #5965. This PR reverts the border to its v4-like thinness.

How to test

  • Is this testable with Jest or Chromatic screenshots? this addon doesn't seem to have tests
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Oct 20, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/7qelx67m8
✅ Preview: https://monorepo-git-fork-connor-baer-bugfix-addon-viewpor-f3a120.storybook.now.sh

@shilman shilman added addon: viewport bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 20, 2019
@shilman shilman requested a review from ndelangen October 20, 2019 03:49
@stale stale bot added the inactive label Nov 10, 2019
@connor-baer
Copy link
Contributor Author

connor-baer commented Nov 10, 2019 •
edited
Loading

This PR is still relevant and waiting for a review :)

Ping @ndelangen

@stale stale bot removed the inactive label Nov 10, 2019
@storybookjs storybookjs deleted a comment from stale bot Nov 15, 2019
ndelangen
ndelangen requested changes Nov 15, 2019
View reviewed changes
addons/viewport/src/Tool.tsx Outdated Show resolved Hide resolved
addons/viewport/src/Tool.tsx Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Dec 6, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 6, 2019
@ndelangen
Copy link
Member

Does anyone else want to pitch in on this?

@stale stale bot removed the inactive label Dec 6, 2019
@shilman shilman added this to the 6.0.0 milestone Dec 20, 2019
@stale stale bot added the inactive label Jan 10, 2020
@connor-baer
Copy link
Contributor Author

@domyen What do you think about this problem? #8486 (comment)

@stale stale bot removed the inactive label Jan 10, 2020
@shilman shilman mentioned this pull request Jan 10, 2020
Merged
3 tasks
@ndelangen ndelangen changed the base branch from next to next-6.0.0 January 11, 2020 00:10
@domyen
Copy link
Member

domyen commented Jan 13, 2020

@connor-baer that sounds good to me! (was on holiday)

Thanks for your attention to detail 🙇‍♂️

@storybookjs storybookjs deleted a comment from stale bot Jan 14, 2020
@vercel vercel bot temporarily deployed to Preview January 14, 2020 10:35 Inactive
@domyen
Copy link
Member

domyen commented Jan 14, 2020

lgtm thank you!

@ndelangen ndelangen merged commit 8470774 into storybookjs:next-6.0.0 Jan 15, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
@connor-baer connor-baer mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@domyen domyen domyen approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
addon: viewport bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@connor-baer @ndelangen @domyen @shilman