Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR addon-viewport & addon-background to FIX buggy behaviour relating to iframe styling && REMOVE recompose #7385

Merged
merged 17 commits into from
Jul 13, 2019

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 11, 2019

Issue:

  • This should decrease the bundlesize a bit, uses hooks over recompose
  • addon-viewport & addon-backgrounds interopt oddly, sometimes styling the iframe itself, sometimes a wrapper.
  • the grid feature should be part of the addon-background

What I did

  • Remove recompose over hooks
  • Make the styling added by addon-viewport & addon-background impact the iframe, not the wrapper
  • Remove the wrapper div
  • Improve the styling of addon-viewport
  • Make viewports centered when smaller then main area
  • Improve the tooltip component usage

ndelangen added 3 commits July 5, 2019 08:12
# Conflicts:
#	lib/ui/src/components/sidebar/SidebarSearch.js
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jul 11, 2019
@vercel
Copy link

vercel bot commented Jul 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-remove-recompose.storybook.now.sh

@vercel vercel bot temporarily deployed to staging July 12, 2019 18:55 Inactive
@vercel vercel bot temporarily deployed to staging July 12, 2019 21:43 Inactive
@vercel vercel bot temporarily deployed to staging July 12, 2019 23:12 Inactive
@ndelangen
Copy link
Member Author

ndelangen commented Jul 12, 2019

Having to tweak a bunch of tools using the tooltip in order to remove recompose, I attended some UI improvements,

  • like the grid tool belongs with the background addon now,
  • the viewports addon uses the new api
  • I found a bug in the setAddonState api, which I fixed
  • viewport is centered, and still scrollable, styling is better too
  • backgrounds & grid apply to the actual iframe now even when combined with the viewport addon

https://youtu.be/U5JYkMuX9h0

@vercel vercel bot temporarily deployed to staging July 12, 2019 23:23 Inactive
@ndelangen ndelangen added this to the 5.2.0 milestone Jul 13, 2019
@ndelangen ndelangen self-assigned this Jul 13, 2019
@ndelangen ndelangen merged commit 91d19fc into next Jul 13, 2019
@ndelangen ndelangen deleted the tech/remove-recompose branch July 13, 2019 09:14
@ndelangen ndelangen changed the title Tech/remove recompose REFACTOR addon-viewport & addon-background to FIX buggy behaviour relating to iframe styling && REMOVE recompose Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant