Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix react inline stories #8419

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Addon-docs: Fix react inline stories #8419

merged 1 commit into from
Oct 15, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 15, 2019

Issue: #6706

What I did

Fixed a bug introduced in #8415 and added a clarifying comment

How to test

See official-storybook docs MDX stories

@vercel
Copy link

vercel bot commented Oct 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/6u7vwt6l0
🌍 Preview: https://monorepo-git-6706-fix-react-inline.storybook.now.sh

@shilman
Copy link
Member Author

shilman commented Oct 15, 2019

Self-merging cc @Aaron-Pool

@shilman shilman added this to the 5.3.0 milestone Oct 15, 2019
@shilman shilman removed the mdx label Oct 15, 2019
@shilman shilman self-assigned this Oct 15, 2019
@shilman shilman merged commit f8ee839 into next Oct 15, 2019
@shilman shilman deleted the 6706-fix-react-inline branch October 15, 2019 06:05
@Aaron-Pool
Copy link
Contributor

@shilman

Cool 👌 was this bug the result of my changes on top of the changes in 5.2 that fixed react hooks? Or did I just forget to check the react kitchen sink for bugs in my testing and this was happening even in the original PR?

@shilman
Copy link
Member Author

shilman commented Oct 15, 2019

@Aaron-Pool No this was a bug I introduced with my latest set of changes in #8415 and wanted to give you a heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants