Addon-docs: Don't error in React when there's no prepareForInline
#8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/3s4o1edll |
|
Won't this still lead to a potentially confusing warning for react users with manual configuration? Because they don't actually need to do anything. Would it be better to just check if the framework is react, and skip the error check if it is? Because, other than react cases, every framework will legit broken if they have specified inline but not provided a prepare for inline hook, yeah? |
shilman
changed the title
prepareForInline isn't set in React
shilman
changed the title
prepareForInline isn't set in ReactprepareForInline
|
Sweet, LGTM now 👍 |
This was referenced Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6706
What I did
The inline rendering contributed in #7929 was actually a breaking change for users who had manually configured their docs setup.
Also removed the storyFn call in React default prepareForInline, which can have implications to React hooks. (Should this be a separate PR?)
How to test
Manually configure an app without
prepareForInlinewith and without the change