Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @storybook/preact to Typescript #7527

Merged
merged 16 commits into from
Jul 30, 2019

Conversation

lonyele
Copy link
Member

@lonyele lonyele commented Jul 23, 2019

Issue: #5030

What I did

I migrated app/preact to Typescript. I've put some caveats on the comments

Thoughts

As I've looked the code, I feel like @storybook/core needs to be migrated first because react, angular, html and preact have same ClientApi that can be done from core. My plan was to migrate some of other frameworks since many of them has a same architecture, but now I'm not sure about it. What do you think of migrating other frameworks? Migrate first and refactor later? Or wait for core to be migrated first and do other frameworks?

@lonyele lonyele added maintenance User-facing maintenance tasks typescript preact labels Jul 23, 2019
@vercel
Copy link

vercel bot commented Jul 23, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-feature-migrate-preact-to-ts.storybook.now.sh

@vercel vercel bot temporarily deployed to staging July 23, 2019 03:19 Inactive
@lonyele
Copy link
Member Author

lonyele commented Jul 23, 2019

About DeepScan

I found that h is needed in preact to wrap transpiled jsx, but DeepScan doesn't like it. It seems like there is a way to resolve this by using webpack plugins, but is it necessary?

About Travis

Travis has failed... Is it because of some actual problem or just it took too much time thus terminated?

app/preact/src/client/preview/index.ts Outdated Show resolved Hide resolved
@ndelangen
Copy link
Member

Awesome work @lonyele ! 👏

@lonyele
Copy link
Member Author

lonyele commented Jul 24, 2019

@ndelangen btw do you think migrating other frameworks now under app folder is a good thing? Just to decide what to do next

As I've looked the code, I feel like @storybook/core needs to be migrated first because react, angular, html and preact have same ClientApi that can be done from core. My plan was to migrate some of other frameworks since many of them has a same architecture, but now I'm not sure about it. What do you think of migrating other frameworks? Migrate first and refactor later? Or wait for core to be migrated first and do other frameworks?

@shilman
Copy link
Member

shilman commented Jul 27, 2019

@lonyele mind fixing the conflicts?

@lonyele lonyele requested a review from shilman as a code owner July 29, 2019 14:54
@vercel vercel bot temporarily deployed to staging July 29, 2019 14:54 Inactive
@lonyele
Copy link
Member Author

lonyele commented Jul 29, 2019

@shilman done!

@ndelangen ndelangen self-assigned this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks preact typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants