-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate @storybook/preact to Typescript #7527
Migrate @storybook/preact to Typescript #7527
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-feature-migrate-preact-to-ts.storybook.now.sh |
About DeepScanI found that About TravisTravis has failed... Is it because of some actual problem or just it took too much time thus terminated? |
Awesome work @lonyele ! 👏 |
@ndelangen btw do you think migrating other frameworks now under
|
@lonyele mind fixing the conflicts? |
@shilman done! |
Issue: #5030
What I did
I migrated
app/preact
to Typescript. I've put some caveats on the commentsThoughts
As I've looked the code, I feel like
@storybook/core
needs to be migrated first becausereact, angular, html and preact
have sameClientApi
that can be done fromcore
. My plan was to migrate some of other frameworks since many of them has a same architecture, but now I'm not sure about it. What do you think of migrating other frameworks? Migrate first and refactor later? Or wait forcore
to be migrated first and do other frameworks?