React/Angular/HTML/Vue: Fix typings for configure
#7598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-7595-fix-configure-types.storybook.now.sh |
4 tasks
nickofthyme
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
@shilman This looks good to me but is there a reason you didn't make these type changes on the ClientApi.configure to be consistent with all the other types/methods defined/exported in these preview/index files?
|
@nickofthyme Probably because I'm an idiot, or because it's nearly 3am here. Take two! 😅 |
|
@shilman nonsense! You need to go to sleep! This is not that important...lol 😅 |
ndelangen
changed the title
ndelangen
added a commit
to lonyele/storybook
that referenced
this pull request
Jul 29, 2019
shilman
changed the title
configure
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7595
What I did
Fix typings