-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix placement of notificationistList on docs page #7290
Fix placement of notificationistList on docs page #7290
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-notifications-docs-page.storybook.now.sh |
@shilman @ndelangen (sorry)I didn't' mean to pester you guys, would you review my PRs? If something looks wrong or implementation is bad please let me know. If it is something I can do it, I definitely can apply feedbacks. Because I have 4 PRs right now I'll just write here once for a simple ping. #7241 I checked that there are not many places using |
@lonyele Thanks for the ping and sorry for the delay on this. I'll take a look at them tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! as you already know. I'm a junior level... I try hard not to take others times away while doing some PRs, but many times it is just a hope... |
Issue: #7289
What I did
I pass
placement
object toNotificationList
so that it renders inside of Component wrapper.Now it looks like this. I left last one
placement
as it is because I thought that is an intended result though I feel like things can be improved