Fix crna-kitchen-sink not working #7200

lonyele · 2019-06-26T03:50:52Z

What I did

I've matched react, react-native, expo sdk version by bumping up

react-native to latest stable version 0.59.9
react-native to sdk 33.0.0
expo version to 33.0.7
expo sdkVersion to 33.0.0

More info

I'm not totally sure but there was a mismatch of react, react-native, expo sdk version.

Possibly introduced from here that upgrading react version from 16.5.1 to 16.8.6
or where expo sdk was not upgraded when the upgrade of react and react-native has happened

I referenced here, here

I'm not sure about bumping up expo-cli or peer-dependencies of react-native to >=0.59 Should I upgrade it?

Personally, ugrading react-native scares me... so if this breaks something please comment on this

How to test

Is this testable with Jest or Chromatic screenshots? No
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

vercel · 2019-06-26T03:50:59Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-crna-kitchen-sink.storybook.now.sh

Gongreg · 2019-06-26T04:19:09Z

Hey @lonyele, thanks for fixing it! :) I never really use CRNA example, so it keeps getting outdated. We should really improve the situation there, maybe having e2e tests will help.

benoitdion · 2019-06-26T12:56:06Z

app/react-native/package.json

-    "@types/react-native": "^0.57.57",
-    "react-native": "^0.57.8"
+    "@types/react-native": "^0.57.64",
+    "react-native": "^0.59.9"


our peer dependency still says "react-native": ">=0.57.0" but it looks like we broke backward compatibility with older version of RN. We may need a deeper look to understand why that happened to see if it can be fixed. With our next major release, we may want to document what version of RN/expo we're going to support and for how long. We should be able to support 0.59 for longer than 0.57 since that's the first version with react hooks support.

yeap It seems like more investigation is needed. I didn't get much from seeing why the deploy/build failed. For now, I don't know what to do next... If you have a guess, can you tell me where to look?

There were few lines of changes yet I didn't see this one. :/
What exactly is the reason to currently lock it to .57 ? What breaking change did we introduce?
And do we need to lock it to .59? If there is need we can do it for next major version I guess.
But I don't think that should be the reason why expo build is failing. I could try to take a look into it too.

the main one is some of the storybook core code started using hooks which weren't supported before 59

Do you know which part? Maybe we can do something about it? Because if we can't change it we have to lock the version and notify people about it.

I'm not really sure, this is mostly a guess 😅

@Gongreg @benoitdion Sorry guys. CI failed because of source-loader problem. After I merged latest next branch, there was no test fail anymore. Though do you guys think merging this PR is safe? Unless upgrading peer-dependency of react-native, it looks ok to me. Because only crna-kitchen-sink gets the upgrade. Not the users using react-native

lonyele · 2019-07-09T12:59:15Z

Hm... CI for build and test looks fine but only now deployement has a problem. What should I do? I don't know why now deployment has failed also I can't rerun the ci...

btw while I was resolving yarn.lock conflict, I messed up the branch so I just started again from the latest next branch and applied the changes(that is why force-pushed is used)

shilman

LGTM @benoitdion are you ok with this?

benoitdion · 2019-07-09T13:45:52Z

I'm ok merging since the peer dependency is version is unchanged but we should still spend time understanding why the bump was required for the kitchen sink app. It could still mean next broke compatibility with RN 0.57

lonyele · 2019-07-09T14:09:41Z

@benoitdion I would just list errors that I've met. Most help is got from here

module schedule/tracking does not exist in the Haste module map error.
--> I've bumped up react-native to the latest
console.error: React Native version mismatch. error. From a search

Sidenote for Expo Users:

If you are using expo, be aware that expo <= 32.0.0 uses a react-native version <= 0.57.2 and therefore will require the react version to be <= 16.5.1

--> Since react was already 16.8.6, I've bumped up all expo related versions to 33.0.0(sdk, expo, react-native)

benoitdion · 2019-07-09T15:32:47Z

it's likely that we are now incompatible with pre-hook versions of react

lonyele · 2019-07-10T12:09:19Z

@benoitdion hm.... I revert back react-native and only left what is in the crna-kitchen-sink and it is working! Come to think of it, app/react-native isn't relevant from the start?

lonyele · 2019-07-19T05:39:20Z

Phew... no errors now. Can you guys check? @shilman @Gongreg

lonyele requested review from danielduan, Gongreg, rmevans9 and tmeasday as code owners June 26, 2019 03:50

vercel bot had a problem deploying to staging June 26, 2019 03:51 Failure

lonyele changed the title ~~fix: mismatch of react, react-native, expo sdk version~~ Fix crna-kitchen-sink not working Jun 26, 2019

lonyele added react-native question / support labels Jun 26, 2019

Gongreg approved these changes Jun 26, 2019

View reviewed changes

benoitdion reviewed Jun 26, 2019

View reviewed changes

vercel bot temporarily deployed to staging July 2, 2019 01:53 Inactive

vercel bot temporarily deployed to staging July 2, 2019 01:55 Inactive

vercel bot had a problem deploying to staging July 2, 2019 01:59 Failure

lonyele added bug doc-dependencies:update and removed doc-dependencies:update labels Jul 2, 2019

vercel bot deployed to staging July 2, 2019 08:18 View deployment

lonyele removed the dependencies:update label Jul 2, 2019

vercel bot deployed to staging July 3, 2019 08:28 View deployment

lonyele force-pushed the fix/crna-kitchen-sink branch from 4fb45a2 to 683fbec Compare July 9, 2019 03:59

vercel bot had a problem deploying to staging July 9, 2019 03:59 Failure

lonyele force-pushed the fix/crna-kitchen-sink branch from 683fbec to e880b3c Compare July 9, 2019 09:19

vercel bot had a problem deploying to staging July 9, 2019 09:19 Failure

lonyele mentioned this pull request Jul 9, 2019

Fix placement of notificationistList on docs page #7290

Merged

shilman approved these changes Jul 9, 2019

View reviewed changes

vercel bot had a problem deploying to staging July 10, 2019 02:40 Failure

lonyele mentioned this pull request Jul 18, 2019

CRNA-kitchen-sink example doesn't work #7199

Closed

lonyele force-pushed the fix/crna-kitchen-sink branch 3 times, most recently from a528f5e to 3fa60c5 Compare July 18, 2019 10:22

vercel bot had a problem deploying to staging July 18, 2019 10:22 Failure

lonyele force-pushed the fix/crna-kitchen-sink branch 2 times, most recently from 683fbec to 12d3777 Compare July 19, 2019 02:31

vercel bot had a problem deploying to staging July 19, 2019 02:31 Failure

lonyele added 2 commits July 19, 2019 13:09

update versions

3d97e02

update yarn.lock

4c46487

lonyele force-pushed the fix/crna-kitchen-sink branch from 12d3777 to 4c46487 Compare July 19, 2019 04:13

vercel bot deployed to staging July 19, 2019 04:13 View deployment

shilman merged commit 7517df6 into storybookjs:next Jul 19, 2019

lonyele deleted the fix/crna-kitchen-sink branch July 29, 2019 15:28

dependencies bot mentioned this pull request Jan 15, 2021

Update 10 dependencies from npm #2477

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crna-kitchen-sink not working #7200

Fix crna-kitchen-sink not working #7200

lonyele commented Jun 26, 2019 •

edited

Loading

vercel bot commented Jun 26, 2019 •

edited

Loading

Gongreg commented Jun 26, 2019

benoitdion Jun 26, 2019

lonyele Jun 26, 2019

Gongreg Jun 26, 2019

benoitdion Jun 26, 2019

Gongreg Jun 26, 2019

benoitdion Jun 26, 2019

lonyele Jul 2, 2019 •

edited

Loading

lonyele commented Jul 9, 2019 •

edited

Loading

shilman left a comment

benoitdion commented Jul 9, 2019

lonyele commented Jul 9, 2019 •

edited

Loading

benoitdion commented Jul 9, 2019

lonyele commented Jul 10, 2019

lonyele commented Jul 19, 2019

Fix crna-kitchen-sink not working #7200

Fix crna-kitchen-sink not working #7200

Conversation

lonyele commented Jun 26, 2019 • edited Loading

What I did

More info

How to test

vercel bot commented Jun 26, 2019 • edited Loading

Gongreg commented Jun 26, 2019

benoitdion Jun 26, 2019

Choose a reason for hiding this comment

lonyele Jun 26, 2019

Choose a reason for hiding this comment

Gongreg Jun 26, 2019

Choose a reason for hiding this comment

benoitdion Jun 26, 2019

Choose a reason for hiding this comment

Gongreg Jun 26, 2019

Choose a reason for hiding this comment

benoitdion Jun 26, 2019

Choose a reason for hiding this comment

lonyele Jul 2, 2019 • edited Loading

Choose a reason for hiding this comment

lonyele commented Jul 9, 2019 • edited Loading

shilman left a comment

Choose a reason for hiding this comment

benoitdion commented Jul 9, 2019

lonyele commented Jul 9, 2019 • edited Loading

benoitdion commented Jul 9, 2019

lonyele commented Jul 10, 2019

lonyele commented Jul 19, 2019

lonyele commented Jun 26, 2019 •

edited

Loading

vercel bot commented Jun 26, 2019 •

edited

Loading

lonyele Jul 2, 2019 •

edited

Loading

lonyele commented Jul 9, 2019 •

edited

Loading

lonyele commented Jul 9, 2019 •

edited

Loading