-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @babel/preset-env
#6281
Conversation
Fix bug introduced by #6267 for older versions of preset-env
I think we should skip 7.4.0 |
Codecov Report
@@ Coverage Diff @@
## next #6281 +/- ##
=======================================
Coverage 38.29% 38.29%
=======================================
Files 648 648
Lines 9839 9839
Branches 387 387
=======================================
Hits 3768 3768
Misses 6011 6011
Partials 60 60 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #6281 +/- ##
=======================================
Coverage 38.29% 38.29%
=======================================
Files 648 648
Lines 9839 9839
Branches 387 387
=======================================
Hits 3768 3768
Misses 6011 6011
Partials 60 60 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue:
What I did
Force us to use latest version of preset-env which supports
corejs
option needed by #6267How to test
Not sure the best way to test. Saw the problem on
master
withofficial-storybook
after trying to patch in #6267 and upgraded there to fix the problem. This PR is a more comprehensive upgrade of allpreset-env
instances.