Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @babel/preset-env #6281

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Upgrade @babel/preset-env #6281

merged 2 commits into from
Mar 26, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 26, 2019

Issue:

What I did

Force us to use latest version of preset-env which supports corejs option needed by #6267

How to test

Not sure the best way to test. Saw the problem on master with official-storybook after trying to patch in #6267 and upgraded there to fix the problem. This PR is a more comprehensive upgrade of all preset-env instances.

Fix bug introduced by #6267 for older versions of preset-env
@shilman shilman changed the title Upgrade babel-preset-env Upgrade @babel/preset-env Mar 26, 2019
@shilman shilman added bug configuration babel / webpack patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 26, 2019
@libetl
Copy link
Member

libetl commented Mar 26, 2019

I think we should skip 7.4.0
codesandbox was failing because of that : https://stackoverflow.com/questions/55250201/cannot-find-module-babel-preset-env-data-built-ins-json

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #6281 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6281   +/-   ##
=======================================
  Coverage   38.29%   38.29%           
=======================================
  Files         648      648           
  Lines        9839     9839           
  Branches      387      387           
=======================================
  Hits         3768     3768           
  Misses       6011     6011           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ed75e...4aaae27. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #6281 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6281   +/-   ##
=======================================
  Coverage   38.29%   38.29%           
=======================================
  Files         648      648           
  Lines        9839     9839           
  Branches      387      387           
=======================================
  Hits         3768     3768           
  Misses       6011     6011           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ed75e...4aaae27. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants