[bug] Enforces corejs v2 for babel #6267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corejs 3 got released which adds noisy warning messages. Force storybook to use corejs 2 instead until proper v3 migration which is breaking change.
mohamedmansour
requested review from
alterx,
igor-dv and
tmeasday
as code owners
|
@shilman can you please label this PR as a bug? Don't know how :( |
mohamedmansour
changed the title
shilman
added
dependencies
bug
configuration babel / webpack
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 26, 2019
[bug] Enforces corejs v2 for babel
shilman
added a commit
that referenced
this pull request
Mar 26, 2019
Fix bug introduced by #6267 for older versions of preset-env
pelotom
added a commit
to pelotom/storybook
that referenced
this pull request
Apr 22, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6261
Corejs 3 got released which adds noisy warning messages. Force storybook
to use corejs 2 instead until proper v3 migration which is breaking change.