Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix up mobile styling #5709

Merged
merged 7 commits into from
Feb 21, 2019
Merged

UI: Fix up mobile styling #5709

merged 7 commits into from
Feb 21, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented Feb 21, 2019

Issue: #5652

What I did

  • Bottom bar should have the same background as the Toolbar
  • Addons panel should be scrollable
  • Addons panel should extend the whole height of the viewport
  • Addons panel should not have "change orientation" or "close" icons
  • Canvas toolbar should not have "fullscreen"

How to test

  • Load SB and resize your screen to <600px

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #5709 into next will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5709      +/-   ##
==========================================
+ Coverage   33.25%   33.27%   +0.02%     
==========================================
  Files         648      648              
  Lines        9362     9366       +4     
  Branches     1355     1355              
==========================================
+ Hits         3113     3117       +4     
  Misses       5634     5634              
  Partials      615      615
Impacted Files Coverage Δ
lib/ui/src/components/preview/preview.js 85.71% <100%> (+0.25%) ⬆️
lib/ui/src/components/panel/panel.js 50% <100%> (+2.94%) ⬆️
lib/ui/src/components/layout/mobile.js 77.14% <50%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedc39f...c58a404. Read the comment docs.

@ndelangen ndelangen merged commit 280abc5 into next Feb 21, 2019
@ndelangen ndelangen deleted the 5652-mobile-styling branch February 21, 2019 21:00
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 22, 2019
@shilman shilman changed the title Fix up mobile styling UI: Fix up mobile styling Feb 22, 2019
shilman pushed a commit that referenced this pull request Feb 22, 2019
@shilman shilman mentioned this pull request Feb 23, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants