Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile styling #5652

Closed
5 tasks done
domyen opened this issue Feb 18, 2019 · 3 comments
Closed
5 tasks done

Mobile styling #5652

domyen opened this issue Feb 18, 2019 · 3 comments
Labels
bug ui
Milestone
v5.0.0

Comments

@domyen
Copy link
Member

domyen commented Feb 18, 2019 •
edited
Loading

Describe the bug
Mobile styling requires improvement. (see expected behavior)

To Reproduce
Steps to reproduce the behavior:

  1. Shrink screen width to mobile size
  2. Click on "nav" or "panel"
  3. See that the bottom bar is incorrect color, and the addons panel has an incorrect backgrounds

Expected behavior

  • Bottom bar should have the same background as the Toolbar
  • Addons panel should be scrollable
  • Addons panel should extend the whole height of the viewport
  • Addons panel should not have "change orientation" or "close" icons
  • Canvas toolbar should not have "fullscreen"

Screenshots

Canvas Sidebar Addons
screen shot 2019-02-18 at 4 46 16 pm screen shot 2019-02-18 at 4 46 22 pm screen shot 2019-02-18 at 4 46 05 pm
@domyen domyen added this to the v5.0.0 milestone Feb 18, 2019
@shilman
Copy link
Member

shilman commented Feb 19, 2019 •
edited
Loading

@domyen Is this a bug or a feature request? I.e. is this existing behavior that's broken, or new behavior that needs to be added?

@domyen domyen self-assigned this Feb 19, 2019
@domyen
Copy link
Member Author

domyen commented Feb 21, 2019

These are bugs. There was another bug that prevented mobile QA that was fixed recently. That's why these bugs are surfacing now.

domyen added a commit that referenced this issue Feb 21, 2019
@domyen
#5652 Add mobile nav bar background
bcb7252
domyen added a commit that referenced this issue Feb 21, 2019
@domyen
#5652 Allow Addons panel to scroll when in mobile
835af50 
Could not figure out why there was a wrapper div around <Panel/>. It appears to work fine without it and fixes the non-scrollable panel bug.
domyen added a commit that referenced this issue Feb 21, 2019
@domyen
#5652 Mobile - Highlight the currently active tab when SB loads
30acf17
domyen added a commit that referenced this issue Feb 21, 2019
@domyen
#5652 Hides desktop-only buttons
848035c
@domyen domyen mentioned this issue Feb 21, 2019
Merged
5 tasks
@domyen domyen removed their assignment Feb 21, 2019
@shilman
Copy link
Member

shilman commented Feb 23, 2019

Whoopee!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.5 containing PR #5709 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
2 participants
@domyen @shilman