React native - Use Core #4942
Merged
React native - Use Core #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager-preset in rn
igor-dv
requested review from
alterx,
danielduan,
Gongreg,
rmevans9 and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## next #4942 +/- ##
=========================================
+ Coverage 37.1% 37.64% +0.54%
=========================================
Files 648 642 -6
Lines 9524 9387 -137
Branches 1381 1334 -47
=========================================
Hits 3534 3534
+ Misses 5411 5293 -118
+ Partials 579 560 -19
Continue to review full report at Codecov.
|
|
Currently, when running an app with expo I am getting the babe6/babel7 mismatch... |
|
upgrading to sdk31 looks solving the babel issue, but there is something new now =/ |
…o solve 'schedule/tracking' issue
shilman
requested changes
Mar 13, 2019
| @@ -22,6 +22,7 @@ if (process.argv[1].includes('getstorybook')) { | |||
| .option('-N --use-npm', 'Use npm to install deps') | |||
| .option('-p --parser <babel | babylon | flow>', 'jscodeshift parser') | |||
| .option('-t --type <type>', 'Add Storybook for a specific project type') | |||
| .option('-y --yes', 'Answer yes to all prompts') | |||
# Conflicts: # addons/ondevice-knobs/package.json # app/react-native/package.json
# Conflicts: # addons/ondevice-knobs/package.json # app/react-native/package.json
…ve as dependency to RN projects (always)
ndelangen
approved these changes
Mar 15, 2019
|
Oops I am late. Yay !! Great Success 💥 |
|
🎉 |
This was referenced Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4879 #4011 #4852 #4332 #5249 #5309
RN was a bit behind for a long time with all the new features we did. In order to support all of the good things, we should reuse as much as possible from the core. Now when the manager and preview are separated it's much easier to do.
@Gongreg, we can maybe continue the #4752 here or create a new branch from this one.
Issues we can also finish for the breaking v5 release:
What I did
moved
src/managerandsrc/previewtosrc/client/*so it will be similar to other appsdeleted all the webpack/babel/config related code from rn/server and replaced it with the
dev-serverfrom corechangeddev-serverto be able to run the webpack only for managerused
standaloneapi to build storybook in a dev moderemoved
--securedparam (-s) and used--httpslike in other appsremoved build command (it was not doing anything).
TBD:
environmentparameter