Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react native -> /dist not needed? #4879

Closed
slorber opened this issue Nov 28, 2018 · 3 comments
Closed

react native -> /dist not needed? #4879

slorber opened this issue Nov 28, 2018 · 3 comments
Labels
cleanup Minor cleanup style change that won't show up in release changelog react-native

Comments

@slorber
Copy link
Contributor

slorber commented Nov 28, 2018

Hi,

"main": "dist/index.js",
  "jsnext:main": "src/index.js",
  "bin": {
    "storybook": "dist/bin/storybook.js"
  },
  "scripts": {
    "prepare": "node ../../scripts/prepare.js"
  },

For ReactNative, the /dist package is not needed because all RN packages are transpiled by Metro by default. Btw Metro does not use jsnext:main so not sure this setting is useful.

Also I tried to run StorybookUI on RN with src and it works fine.

Just wanted to mention that, not sure exactly what should be done but I suspect it's not needed to transpile / use the whole src folder. Maybe it's needed for the storybook bin which start the web server ?

@Gongreg
Copy link
Member

Gongreg commented Nov 29, 2018

Hey @slorber, you are correct, the transpilation is unneeded for preview folder in react-native. It is necessary for server part. Moving forward we will separate preview part from server part to a separate module. There is a PR for that done by me, but it is a little bit stale so I will have to redo it.

@Gongreg Gongreg added react-native cleanup Minor cleanup style change that won't show up in release changelog labels Nov 29, 2018
@igor-dv igor-dv mentioned this issue Dec 6, 2018
8 tasks
@stale
Copy link

stale bot commented Dec 20, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 20, 2018
@Gongreg Gongreg added todo and removed inactive labels Dec 20, 2018
@Gongreg Gongreg closed this as completed Dec 20, 2018
@issue-sh issue-sh bot removed the todo label Dec 20, 2018
@shilman
Copy link
Member

shilman commented Mar 16, 2019

Ooh-la-la!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.7 containing PR #4942 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog react-native
Projects
None yet
Development

No branches or pull requests

3 participants