-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Introducing Bun for Script Execution #28046
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
ci:daily
Run the CI jobs that normally run in the daily job.
build
Internal-facing build tooling & test updates
labels
Jun 6, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 84d2574. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Verdaccio occasionally hangs locally after publishing all packages. Even a process.exit doesn't help due to the following error: pinojs/thread-stream#36 Upgrading pino to v9 resolves the issue
valentinpalkovic
force-pushed
the
valentin/bun
branch
from
June 10, 2024 12:03
6775fb9
to
4478cc5
Compare
Verdaccio doesn't seem to run in a bun runtime appropriately. It seems to have issues to establish a connection to the npmjs proxy.
valentinpalkovic
force-pushed
the
valentin/bun
branch
from
June 19, 2024 07:43
33ff68a
to
ec50aa0
Compare
valentinpalkovic
force-pushed
the
valentin/bun
branch
from
June 25, 2024 08:03
e841af0
to
e9713a1
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
This PR introduces a significant change to our script execution process. We are now using Bun, a powerful tool for running scripts from the scripts directory. Bun provides a simple and efficient way to manage and run our scripts, improving our development workflow.
To start using Bun locally, you will need to install it. You can do this by running the following command in your terminal:
curl -fsSL https://bun.sh/install | bash
Once Bun is installed, you can run for example the
yarn task
command as usual.In addition to introducing Bun, this PR also includes an update to our execa configuration. I've updated execa to the latest version and made some changes to its configuration. Please note that Bun currently does not support inheriting stdio from the main process, so we've configured execa to handle this aspect of our script execution process.
The most important work is split into the following chunks
Motivation
Previously, we used esbuild-register for on-the-fly transformation of ECMAScript modules (ESM) to CommonJS (CJS). However, we encountered a significant bug in esbuild-register when using it with newer Node.js versions (20.6.0 and above). This bug has been open for a while and doesn't seem to be getting fixed in the near future.
Moreover, the use of esbuild-register was somewhat counterproductive to our long-term goal. We plan to phase out the use of CommonJS in favor of ECMAScript modules. The on-the-fly transformation of ESM to CJS by esbuild-register was a step away from this goal.
By switching to Bun, we are not only circumventing the bug in esbuild-register, but also taking a step closer to our goal of fully adopting ECMAScript modules. Bun's built-in TypeScript support allows us to write our scripts directly in TypeScript and run them as ECMAScript modules, eliminating the need for on-the-fly transformations to CommonJS.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>