Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Re-enable Storybook in Vite Ecosystem CI #26493

Open
shilman opened this issue Mar 14, 2024 · 0 comments
Open

Build: Re-enable Storybook in Vite Ecosystem CI #26493

shilman opened this issue Mar 14, 2024 · 0 comments
Labels
bug build Internal-facing build tooling & test updates builder-vite

Comments

@shilman
Copy link
Member

shilman commented Mar 14, 2024

Describe the bug

Once upon a time, Storybook was part of https://github.com/vitejs/vite-ecosystem-ci. At some point it broke, and was removed. Now every time Vite makes a change, maintainers don't know whether they've broken Storybook.

There is a draft PR to re-enable it: vitejs/vite-ecosystem-ci#137. We should pick that up and take it over the line, or start again if that's easier.

Update 30 July 2024

The initial PR got superseded by vitejs/vite-ecosystem-ci#311 where we provided scripts for the vite-ecosystem CI inside of our monorepository. The problem is that our scripts depend on esbuild-register, which currently has a bug preventing us from continuing our second attempt at integrating Storybook into the Vite Ecosystem CI.

To circumvent the esbuild-register solution, we planned to continue @ndelangen work to move away from esbuild-register and to use bun instead, which is already used for some tasks. This PR tries to do the migration.

Even after multiple attempts, we could not migrate fully to Bun at the moment. Bun has some different behaviors from Node.js. For example, we had huge issues to make `

Third attempt

Instead of trying to integrate Storybook into Vite's Ecosystem CI via our sandboxes repo (first attempt) or by integrating Storybook by using our mono repository (second attempt), we want to initialize a fresh repository exclusively for Vite's Ecosystem CI. We want to modify our daily sandbox publishing script to release a react-vite sandbox into a separate repository. The package.json of this repo will provide scripts for Vite's ecosystem CI to install dependencies and to run the test-runner to execute tests.

The scripts we will provide will be the following:

  • vite-ecosystem-ci:test: Running the @storybook/test-runner
@shilman shilman added bug builder-vite build Internal-facing build tooling & test updates labels Mar 14, 2024
@shilman shilman moved this to Empathy Backlog in Core Team Projects Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build Internal-facing build tooling & test updates builder-vite
Projects
Status: Empathy Backlog
Development

No branches or pull requests

2 participants