Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix logos display & add babelrc #2585

Merged
merged 6 commits into from
Dec 28, 2017
Merged

Docs: fix logos display & add babelrc #2585

merged 6 commits into from
Dec 28, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Dec 27, 2017

Issue:
— "Used by" logos are not displayed on docsite: http://storybooks.netlify.com/
— Docs package don't work without root dependencies (see #2203)

It turns out that it's enough to add an empty .babelrc as gatsby's defaults work OK.

How to test

In project root:

rm -rf node_modules
cd docs
yarn install
yarn dev

@Hypnosphi Hypnosphi added documentation maintenance User-facing maintenance tasks labels Dec 27, 2017
@Hypnosphi Hypnosphi changed the title Docs babelrc Docs: fix logos display & add babelrc Dec 27, 2017
@codecov
Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #2585 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2585   +/-   ##
=======================================
  Coverage   32.68%   32.68%           
=======================================
  Files         398      398           
  Lines        8838     8838           
  Branches      947      943    -4     
=======================================
  Hits         2889     2889           
+ Misses       5296     5293    -3     
- Partials      653      656    +3
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
addons/actions/src/lib/reviver.js 58.33% <0%> (ø) ⬆️
addons/a11y/src/components/WrapStory.js 72.09% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4e6b8...d7dd426. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 82804ae into master Dec 28, 2017
@Hypnosphi Hypnosphi deleted the docs-babelrc branch December 28, 2017 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants