-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for need of main package dependecies #2203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2203 +/- ##
=======================================
Coverage 21.19% 21.19%
=======================================
Files 283 283
Lines 6156 6156
Branches 732 731 -1
=======================================
Hits 1305 1305
+ Misses 4301 4292 -9
- Partials 550 559 +9
Continue to review full report at Codecov.
|
Thanks @mccullochk ! Maybe we're just missing a few dependencies in the I don't think this flow where you need to bootstrap the core in order to develop on the docs is the intention. |
@ndelangen, it actually doesn't look like there is a missing dependency. I added all the core dependencies to the |
Ah so basicly what we need to do is create a |
Yes. Sorry if my first solution was misleading. I can change this pull request to include a The {
"presets": ["env", "stage-0", "react"],
"plugins": [
["transform-runtime", {
"polyfill": false,
"regenerator": true
}]
]
} |
Yeah, that would be great |
@Hypnosphi is this still relevant with your upgrade of gatsby? |
I didn't touch the Babel stuff, so probably yes |
@mccullochk do you still want to take care of this one? |
@ndelangen are you sure we don’t want to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See conversation
Fine either way, thb What do you prefer? |
Codecov Report
@@ Coverage Diff @@
## master #2203 +/- ##
=======================================
Coverage 32.68% 32.68%
=======================================
Files 398 398
Lines 8838 8838
Branches 962 964 +2
=======================================
Hits 2889 2889
+ Misses 5278 5258 -20
- Partials 671 691 +20
Continue to review full report at Codecov.
|
I'd say we should either include docs into workspaces, or keep it as an isolated package. In the latter case, it should work without bootstrapping everything else |
Ok, my gut feeling would be to keep them isolated, do you agree? |
Sure |
@mccullochk Is this something you could do? We'd like to be able to install & run the docs -WITHOUT- having to bootstrap the core. 👍 |
Superseded by #2585 |
Issue
If you clone the repository and only run
yarn install
in the/docs
directory and not in the root (/
) directory, you get the following error.ReferenceError: Unknown plugin "transform-runtime" specified in "/Users/_name_/Documents/personal/projects/storybook/.babelrc" at 0, attempted to resolve relative to "/Users/_name_/Documents/personal/projects/storybook"
What I did
Documented the dependency need in hopes of helping future users avoid the
ReferenceError