-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST3 Release: Prerelease 7.5.0-alpha.5 #24385
Closed
github-actions
wants to merge
547
commits into
latest-release
from
version-non-patch-from-7.5.0-alpha.4
Closed
TEST3 Release: Prerelease 7.5.0-alpha.5 #24385
github-actions
wants to merge
547
commits into
latest-release
from
version-non-patch-from-7.5.0-alpha.4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indexer: Rename `index` to `createIndex`
This is the error that was happening: ``` /Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:262 throw new Error( ^ Error: @swc/core threw an error when attempting to validate swc compiler options. You may be using an old version of swc which does not support the options used by ts-node. Try upgrading to the latest version of swc. Error message from swc: Failed to deserialize buffer as swc::config::Options JSON: {"sourceMaps":true,"module":{"noInterop":false,"type":"commonjs","strictMode":true,"ignoreDynamic":false},"swcrc":false,"jsc":{"parser":{"syntax":"typescript","tsx":false,"dynamicImport":true,"importAssertions":true},"target":"es2020","transform":{"legacyDecorator":true,"react":{"throwIfNamespace":false,"useBuiltins":false}},"keepClassNames":true,"experimental":{"keepImportAssertions":true}}} Caused by: unknown field `keepImportAssertions`, expected one of `plugins`, `keepImportAttributes`, `emitAssertForImportAttributes`, `cacheRoot`, `disableBuiltinTransformsForInternalTesting` at line 1 column 395 at createVariant (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:262:13) at createSwcOptions (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:211:25) at create (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:56:41) at createTranspiler (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/index.ts:784:16) at createTranspileOnlyGetOutputFunction (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/index.ts:1341:28) at createFromPreloadedConfig (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/index.ts:1404:34) at phase4 (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:543:44) at bootstrap (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:95:10) at main (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:55:10) at Object.<anonymous> (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:800:3) ```
The error I was getting: ``` FAIL frameworks/angular/src/client/docs/angular-properties.test.ts ● Test suite failed to run Cannot find module 'zone.js/bundles/zone-testing-bundle.umd' from 'node_modules/jest-preset-angular/setup-jest.js' Require stack: node_modules/jest-preset-angular/setup-jest.js setup-jest.ts 1 | // eslint-disable-next-line import/no-extraneous-dependencies > 2 | import 'jest-preset-angular/setup-jest'; | ^ 3 | 4 | import { webcrypto } from 'node:crypto'; 5 | at Resolver._throwModNotFoundError (../../node_modules/jest-resolve/build/resolver.js:427:11) at Object.<anonymous> (node_modules/jest-preset-angular/setup-jest.js:1:103) at Object.<anonymous> (setup-jest.ts:2:1) ```
The error I was getting: ``` FAIL frameworks/angular/src/client/docs/angular-properties.test.ts ● Test suite failed to run Cannot find module 'zone.js/bundles/zone-testing-bundle.umd' from 'node_modules/jest-preset-angular/setup-jest.js' Require stack: node_modules/jest-preset-angular/setup-jest.js setup-jest.ts 1 | // eslint-disable-next-line import/no-extraneous-dependencies > 2 | import 'jest-preset-angular/setup-jest'; | ^ 3 | 4 | import { webcrypto } from 'node:crypto'; 5 | at Resolver._throwModNotFoundError (../../node_modules/jest-resolve/build/resolver.js:427:11) at Object.<anonymous> (node_modules/jest-preset-angular/setup-jest.js:1:103) at Object.<anonymous> (setup-jest.ts:2:1) ```
Types: Don't distribute generic type of Meta and Story
…tember Maintenance: Regen lockfiles
Docs: Adds video to the Install page
Sandboxes: Fix scripts when pre-existing `NODE_OPTIONS` contains whitespaces
…rybook into release-stable-to-latest
Build: Always set `--no-link` when creating angular sandboxes
Angular: Fix Angular 15 support and add zone.js v0.14.x support
NextJS: Fix default next image loader when src has params
Release tooling: Release stable releases from `latest-release`
…xt-2 NextJS: Fix Image Context re-use via singleton
github-actions
bot
requested review from
JReinhold,
cdedreuille,
tmeasday,
kasperpeulen,
shilman,
valentinpalkovic,
yannbf,
IanVS,
kylegach,
jonniebigodes and
vanessayuenn
as code owners
October 5, 2023 12:47
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
7.5.0-alpha.4
to7.5.0-alpha.5
.Once this pull request is merged, it will trigger a new release of version
7.5.0-alpha.5
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:react-docgen
to 6.0.x and improve argTypes #23825latest-release
v3 #24382latest-release
" #24379latest-release
#24106 (will also be patched)--no-link
when creating angular sandboxes #24373If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
7.5.0-alpha.5
react-docgen
to 6.0.x and improve argTypes - #23825, thanks @ shilman!