Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Adds video to the Install page #24144

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

jonniebigodes
Copy link
Contributor

What I did

With this pull request the Get started / Install page was updated to feature the latest video by @chantastic

Checklist for Contributors

Testing

  1. Follow the steps in the contributing instructions for this branch, docs_add_video_install.
  2. Open the relevant documentation, and the videos should be available.

@chantastic and @kylegach, when you have a moment, can you take a look at this and let me know of any feedback you have? Thanks in advance.

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Sep 11, 2023
@jonniebigodes jonniebigodes self-assigned this Sep 11, 2023
Copy link

@chantastic chantastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for always getting these into docs so quickly!

I'm excited to see if this helps users in their getting started adventures.

@jonniebigodes
Copy link
Contributor Author

jonniebigodes commented Sep 12, 2023

@chantastic, no problem whatsoever, and same here. Appreciate you taking the time to review this and approve it 🙏 . Going to go ahead and merge this to get it added as soon as possible

@jonniebigodes jonniebigodes merged commit 01aa0e8 into next Sep 12, 2023
15 checks passed
@jonniebigodes jonniebigodes deleted the docs_add_video_install branch September 12, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants