Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Improve tabs component, more type correct, allow for FC as title #23288

Merged
merged 22 commits into from
Jul 6, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 3, 2023

This targets release/7.2 to not disrupt the 7.1 release.

What I did

  • improve the Tabs component to have better types
  • the title can be a FC now
  • improve the Addon interface to accept the FC as title as well
  • split the Addon interface into Addon_BaseType for future use

How to test

  • build should succeed
  • yarn check should pass
  • no UI changes detected by chromatic (except for new stories)
  • there should be no perf changes in anything related to tabs or addons

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Sorry, something went wrong.

@ndelangen ndelangen self-assigned this Jul 3, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jul 3, 2023
@ndelangen ndelangen changed the title make tabs component more type correct, allow for FC as title UI: Improve tabs component, more type correct, allow for FC as title Jul 3, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Jul 3, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, I've left a few comments.

code/lib/manager-api/src/lib/addons.ts Show resolved Hide resolved
code/lib/types/src/modules/addons.ts Outdated Show resolved Hide resolved
code/ui/components/src/tabs/tabs.helpers.tsx Show resolved Hide resolved
code/ui/components/src/tabs/tabs.stories.tsx Outdated Show resolved Hide resolved
code/ui/components/src/tabs/tabs.tsx Outdated Show resolved Hide resolved
code/lib/types/src/modules/addons.ts Show resolved Hide resolved
@ndelangen ndelangen requested a review from JReinhold July 6, 2023 15:32
@ndelangen ndelangen merged commit 8e1dbba into release/7.2 Jul 6, 2023
@ndelangen ndelangen deleted the norbert/ui-tabs-types-improvements branch July 6, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants