-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon API: Add experimental page
addon type
#23307
Conversation
…ignores your selection
…/storybook into norbert/page-addons-refactor
code/lib/preview-api/src/modules/preview-web/PreviewWithSelection.tsx
Outdated
Show resolved
Hide resolved
…ion.tsx Co-authored-by: Tom Coleman <[email protected]>
…re no longer needed. This is not a breaking change, just logs a warning from react as far as i can see
page
addon type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the review you mentioned that there is a breaking TS change where Addon_Type
's type
field is now required. Please add this to MIGRATION.md
.
I love the use of experimental_
in the name. Playwright also does this and I think it's a great convention -- we should do more.
…/storybook into norbert/page-addons-refactor
@shilman I don't think the I did end up writing some migration guide bits for the increased strictness of the manager-api |
What I did
page
(prefix with experimental for now)/
even if there's no query/settings
was before)How to test
/
: expect the story to be shown/settings/about
: expect the about page to be shown/debugger
: expect the debugger panel to be showndebugger
page : expect the route to change, and the first story to be shownI have done the best I can to have some of this also make sense for the mobile view, but this is really up for grabs. We need to determine what to do regarding pages for mobile.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]