Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Point upgrade script to latest #21936

Merged
merged 9 commits into from
Apr 5, 2023

Conversation

kasperpeulen
Copy link
Contributor

What I did

Make sure that upgrade script point to latest. Otherwise the locally installed version of the storybook binary may be used.

How to test

Try it out in a storybook 6 project where the storybook package is installed.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen requested a review from yannbf April 5, 2023 08:02
@kasperpeulen kasperpeulen self-assigned this Apr 5, 2023
@kasperpeulen kasperpeulen changed the base branch from next to main April 5, 2023 08:03
@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 5, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasperpeulen thanks for taking the time to put together this pull request. Appreciate it. Checked and all is good on my end. Going to merge once the checklist clears

@shilman
Copy link
Member

shilman commented Apr 5, 2023

@kasperpeulen @jonniebigodes all PRs to next please during stabilization.

@shilman shilman changed the base branch from main to next April 5, 2023 11:54
@jonniebigodes
Copy link
Contributor

Appreciate the reminder @shilman . Thank you 🙏

@jonniebigodes jonniebigodes merged commit 042ba22 into next Apr 5, 2023
@jonniebigodes jonniebigodes deleted the kasper/point-upgrade-script-to-latest branch April 5, 2023 13:10
@kasperpeulen
Copy link
Contributor Author

@shilman @jonniebigodes But wait, merging to next won't update the docs of 7.0 right?

@shilman
Copy link
Member

shilman commented Apr 5, 2023

Please read the proposal I sent out to the team that explains the workflow @kasperpeulen

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
…t-to-latest

Docs: Point upgrade script to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants