Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Migration Guide snippets #21931

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Update Migration Guide snippets #21931

merged 1 commit into from
Apr 5, 2023

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Apr 4, 2023

What I did

Follow-up to #21918 because I made some mistakes

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach self-assigned this Apr 4, 2023
@jonniebigodes jonniebigodes mentioned this pull request Apr 4, 2023
Merged
5 tasks
@kylegach kylegach mentioned this pull request Apr 4, 2023
Closed
jonniebigodes
jonniebigodes approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylegach all good, thanks for the updates! Appreciate it. Merge when able.

@kylegach kylegach force-pushed the update-migration-guide-for-main-2 branch from ea69689 to 9867da0 Compare April 4, 2023 20:57
@shilman shilman merged commit ccff88f into main Apr 5, 2023
@shilman shilman deleted the update-migration-guide-for-main-2 branch April 5, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonniebigodes jonniebigodes jonniebigodes approved these changes

Assignees

@kylegach kylegach

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylegach @jonniebigodes @shilman