Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add code snippets for yarn pnp in migration-guide #21919

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Docs: Add code snippets for yarn pnp in migration-guide #21919

merged 4 commits into from
Apr 11, 2023

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Apr 4, 2023

Closes #21895

What I did

Updates the docs to include commands for yarn pnp for migrating.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackw thanks for taking the time to create this pull request and help us improve our documentation. We appreciate it. I left a small item that requires your attention and this should be good to go.

Let me know once you've addressed it and we'll take it from there.

Hope you have a great day.

Stay safe

docs/migration-guide.md Outdated Show resolved Hide resolved
@jackw
Copy link
Contributor Author

jackw commented Apr 5, 2023

Let me know once you've addressed it and we'll take it from there.

@jonniebigodes I've updated the PR as requested. Let me know if you need anything more from my side.

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackw sorry for the delayed response 🙏 . I just have one final item for you to address so that we can merge this pull request.

Let me know once you have addressed the feedback and I'll gladly merge it.

Hope you have a great week

Stay safe

docs/snippets/common/init-command.yarn.js.mdx Outdated Show resolved Hide resolved
@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 10, 2023
@jonniebigodes
Copy link
Contributor

@jackw Thanks for making the changes so promptly. I just got the notification about the latest commit. I'm going to merge this pull request once the checklist clears. Once again, thank you so much for taking the time to put together this pull request and help us improve our documentation 🙏

@jonniebigodes jonniebigodes merged commit 56882b7 into storybookjs:next Apr 11, 2023
@jackw jackw deleted the yarn-migration-instructions branch April 11, 2023 19:35
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 12, 2023
shilman pushed a commit that referenced this pull request Apr 12, 2023
Docs: Add code snippets for yarn pnp in migration-guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: storybook init (v7) fails with Yarn PnP
3 participants