-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add code snippets for yarn pnp in migration-guide #21919
Docs: Add code snippets for yarn pnp in migration-guide #21919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackw thanks for taking the time to create this pull request and help us improve our documentation. We appreciate it. I left a small item that requires your attention and this should be good to go.
Let me know once you've addressed it and we'll take it from there.
Hope you have a great day.
Stay safe
@jonniebigodes I've updated the PR as requested. Let me know if you need anything more from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackw sorry for the delayed response 🙏 . I just have one final item for you to address so that we can merge this pull request.
Let me know once you have addressed the feedback and I'll gladly merge it.
Hope you have a great week
Stay safe
@jackw Thanks for making the changes so promptly. I just got the notification about the latest commit. I'm going to merge this pull request once the checklist clears. Once again, thank you so much for taking the time to put together this pull request and help us improve our documentation 🙏 |
Docs: Add code snippets for yarn pnp in migration-guide
Closes #21895
What I did
Updates the docs to include commands for yarn pnp for migrating.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]