Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix glitchy range control #21459

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Mar 7, 2023

Issue: #21191

What I did

  • Fixed width of current / max label width to avoid slider width changing which is the reason of buggy in Range control

How to test

  • Run yarn storybook:ui in code dir
  • Navigate to Range story
  • Verify that Range works without bug

This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

Co-authored-by: BikashSah999 <[email protected]>
@gitstart gitstart marked this pull request as ready for review March 7, 2023 15:43
@shilman shilman changed the title UI: Fix Range control buggy Controls: Fix glitchy range control Mar 13, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! 💪

@JReinhold JReinhold merged commit f751229 into storybookjs:next Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants