Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Range control is buggy #21191

Closed
Spielboerg opened this issue Feb 21, 2023 · 1 comment
Closed

[Bug]: Range control is buggy #21191

Spielboerg opened this issue Feb 21, 2023 · 1 comment

Comments

@Spielboerg
Copy link
Contributor

Describe the bug

If a high negative minimum and a high positive maximum value is used for a range control, the slide control will wobble around zero:

Storybook.Range.Bug.mp4

It occurs more often the shorter the sliding element is, but can also be seen when wider.

My control config:

argTypes: {
  test: {
    control: {
      type: 'range',
      min: -180,
      max: 180,
      step: 1
    }
  }
}

There is also a slight wobble around 100 when switching to this configuration:

{
  type: 'range',
  min: 0,
  max: 360,
  step: 1
}
Storybook.Range.Bug.2.mp4

To Reproduce

Reproduction: https://githubaw2ttw-w451--6006.local-credentialless.webcontainer.io/?path=/story/bug-demo--default

Code of the reproduction: https://stackblitz.com/edit/github-aw2ttw?file=src/stories/Page.stories.js

System

Environment Info (my computer):

  System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.18.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 110.0.5481.100
    Firefox: 110.0
    Safari: 16.3
  npmPackages:
    @storybook/addon-docs: ^6.5.10 => 6.5.16 
    @storybook/addon-essentials: ^6.5.16 => 6.5.16 
    @storybook/addon-links: ^6.5.16 => 6.5.16 
    @storybook/addons: ^6.5.10 => 6.5.16 
    @storybook/builder-webpack5: ^6.5.16 => 6.5.16 
    @storybook/manager-webpack5: ^6.5.16 => 6.5.16 
    @storybook/preset-create-react-app: ^4.1.2 => 4.1.2 
    @storybook/react: ^6.5.16 => 6.5.16 
    @storybook/testing-library: ^0.0.13 => 0.0.13 
    @storybook/theming: ^6.5.10 => 6.5.16 

---

Environment Info (Reproduction on Stackblitz):

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    @storybook/addon-essentials: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/addon-interactions: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/addon-links: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/blocks: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/node-logger: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/preset-create-react-app: ^4.1.2 => 4.1.2 
    @storybook/react: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/react-webpack5: ^7.0.0-beta.47 => 7.0.0-beta.52 
    @storybook/testing-library: ^0.0.14-next.1 => 0.0.14-next.1

Additional context

No response

@shilman
Copy link
Member

shilman commented Mar 17, 2023

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.4 containing PR #21459 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants