-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Allow a teardown function to be returned from renderToDOM
#18457
Merged
shilman
merged 45 commits into
next
from
tom/sb-415-return-cleanup-function-from-rendertodom
Jun 20, 2022
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
4c80c21
Allow a teardown function to be returned from `renderToDOM`
tmeasday 06e4c29
Add integration tests for teardown function
tmeasday 95d3f32
Update addons/docs/src/blocks/Story.tsx
tmeasday 3a57672
Update snapshots
tmeasday 383b5b5
Fixed PnP compatibility for bundled ui and router packages
Andarist d7cb989
chore(CI): reenable cra pnp tests
yannbf d66cb53
fix: change the way presets are required
yannbf d2928de
telemetry: strip out preset from addon name
yannbf 31aef64
Warn when storyName usage is detected in CSF3 stories
joshwooding f1ae954
Move memoizerific to dependencies in theming
joshwooding 8335942
Move memoizerific and qs to dependencies in router
joshwooding d410bd9
Move memoizerific and qs to dependencies in ui
joshwooding e1d7f08
Core: Fix process is not defined when using components
joshwooding d35bc15
Remove duplicate statement
mattevenson f92dd04
bundle the syntax highlighter again inside lib/components
ndelangen 2e9fb44
Update test-runner.md
alexguja f19b470
fix: display skip to sidebar button
darleendenno d5b741e
Don't intercept calls inside callbacks, and bubble exceptions inside …
ghengeveld 3bcec76
Show child interactions in log and display errors in the appropriate …
ghengeveld 1ea2f9c
Fix mock data
ghengeveld 136c121
Fix exception type
ghengeveld ee7baf2
Disable interaction on child interactions
ghengeveld 6f42962
Many fixes
ghengeveld edc79c9
Remove unused eslint directives
ghengeveld 3364473
Fix prop forwarding
ghengeveld ea77b6d
Fix back button
ghengeveld dbcf78b
Fix pausedAt indicator
ghengeveld 6d540e0
Fix broken play function
ghengeveld 1605cbb
Value might be null
ghengeveld 1fa16ca
Tweak indicator style
ghengeveld 249496f
Fix rendering inconsistency
ghengeveld fcf5728
Fix zIndex
ghengeveld 41913b6
Fix tests
ghengeveld 2509e7e
Fix story data
ghengeveld 3b668db
Show pausedAt indicator in story
ghengeveld b134d72
Better story data
ghengeveld 18cf8c6
Add story book interaction row with parentId
ghengeveld 2e23d67
Better story data
ghengeveld 3285a9e
Collapse child interactions
ghengeveld e39fb22
Expand by default
ghengeveld aa7f2b6
Tweak anonymous function color
ghengeveld 6fdd19c
Update addons/interactions/src/components/Interaction/Interaction.tsx
ghengeveld 7b313ae
Merge remote-tracking branch 'origin/next' into tom/sb-415-return-cle…
tmeasday f0169ca
Use node14 in netlify
tmeasday 661011f
Merge branch 'next' into tom/sb-415-return-cleanup-function-from-rend…
shilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { Button } from './button'; | ||
|
||
export default { | ||
component: Button, | ||
title: 'button2', | ||
}; | ||
|
||
export const one = { args: { label: 'one' } }; | ||
export const two = { args: { label: 'two' } }; | ||
export const three = { args: { label: 'three' } }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { Button } from './button'; | ||
|
||
export default { | ||
component: Button, | ||
title: 'button3', | ||
}; | ||
|
||
export const four = { args: { label: 'four' } }; | ||
export const five = { args: { label: 'five' } }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we patch this back we should make sure we don't include this change (in fact should we take it out until we've considered this properly?)