Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Allow a teardown function to be returned from renderToDOM #18457

Merged
merged 45 commits into from
Jun 20, 2022
Merged

Core: Allow a teardown function to be returned from renderToDOM #18457

merged 45 commits into from
Jun 20, 2022

Commits on Jun 10, 2022

  1. Allow a teardown function to be returned from renderToDOM

    @tmeasday
    tmeasday committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    4c80c21 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Add integration tests for teardown function

    @tmeasday
    tmeasday committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    06e4c29 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Update addons/docs/src/blocks/Story.tsx 

    Co-authored-by: Michael Shilman <[email protected]>
    @tmeasday @shilman
    tmeasday and shilman authored Jun 16, 2022
    Configuration menu
    Copy the full SHA
    95d3f32 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Update snapshots

    @tmeasday
    tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3a57672 View commit details
    Browse the repository at this point in the history

  2. Fixed PnP compatibility for bundled ui and router packages

    @Andarist @tmeasday
    Andarist authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    383b5b5 View commit details
    Browse the repository at this point in the history

  3. chore(CI): reenable cra pnp tests

    @yannbf @tmeasday
    yannbf authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d7cb989 View commit details
    Browse the repository at this point in the history

  4. fix: change the way presets are required

    @yannbf @tmeasday
    yannbf authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d66cb53 View commit details
    Browse the repository at this point in the history

  5. telemetry: strip out preset from addon name 

    also move getStorybookMetadata method to the bottom so it's used after the definition
of computeStorybookMetadata
    @yannbf @tmeasday
    yannbf authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d2928de View commit details
    Browse the repository at this point in the history

  6. Warn when storyName usage is detected in CSF3 stories

    @joshwooding @tmeasday
    joshwooding authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    31aef64 View commit details
    Browse the repository at this point in the history

  7. Move memoizerific to dependencies in theming

    @joshwooding @tmeasday
    joshwooding authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    f1ae954 View commit details
    Browse the repository at this point in the history

  8. Move memoizerific and qs to dependencies in router

    @joshwooding @tmeasday
    joshwooding authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    8335942 View commit details
    Browse the repository at this point in the history

  9. Move memoizerific and qs to dependencies in ui

    @joshwooding @tmeasday
    joshwooding authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d410bd9 View commit details
    Browse the repository at this point in the history

  10. Core: Fix process is not defined when using components

    @joshwooding @tmeasday
    joshwooding authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e1d7f08 View commit details
    Browse the repository at this point in the history

  11. Remove duplicate statement 

    `title: 'DocumentScreen',` appears twice in the component meta.
    @mattevenson @tmeasday
    mattevenson authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d35bc15 View commit details
    Browse the repository at this point in the history

  12. bundle the syntax highlighter again inside lib/components

    @ndelangen @tmeasday
    ndelangen authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    f92dd04 View commit details
    Browse the repository at this point in the history

  13. Update test-runner.md 

    Make code snippet consistent with the others on the page. Typically yarn is shown before npm, so this change will make the code snippet consistent with the rest.
    @alexguja @tmeasday
    alexguja authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2e9fb44 View commit details
    Browse the repository at this point in the history

  14. fix: display skip to sidebar button

    @darleendenno @tmeasday
    darleendenno authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    f19b470 View commit details
    Browse the repository at this point in the history

  15. Don't intercept calls inside callbacks, and bubble exceptions inside … 

    …callbacks up to the parent rather than forwarding it to the next interceptable call
    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d5b741e View commit details
    Browse the repository at this point in the history

  16. Show child interactions in log and display errors in the appropriate … 

    …place
    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3bcec76 View commit details
    Browse the repository at this point in the history

  17. Fix mock data

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    1ea2f9c View commit details
    Browse the repository at this point in the history

  18. Fix exception type

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    136c121 View commit details
    Browse the repository at this point in the history

  19. Disable interaction on child interactions

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    ee7baf2 View commit details
    Browse the repository at this point in the history

  20. Many fixes

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    6f42962 View commit details
    Browse the repository at this point in the history

  21. Remove unused eslint directives

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    edc79c9 View commit details
    Browse the repository at this point in the history

  22. Fix prop forwarding

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3364473 View commit details
    Browse the repository at this point in the history

  23. Fix back button

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    ea77b6d View commit details
    Browse the repository at this point in the history

  24. Fix pausedAt indicator

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    dbcf78b View commit details
    Browse the repository at this point in the history

  25. Fix broken play function

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    6d540e0 View commit details
    Browse the repository at this point in the history

  26. Value might be null

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    1605cbb View commit details
    Browse the repository at this point in the history

  27. Tweak indicator style

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    1fa16ca View commit details
    Browse the repository at this point in the history

  28. Fix rendering inconsistency

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    249496f View commit details
    Browse the repository at this point in the history

  29. Fix zIndex

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    fcf5728 View commit details
    Browse the repository at this point in the history

  30. Fix tests

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    41913b6 View commit details
    Browse the repository at this point in the history

  31. Fix story data

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2509e7e View commit details
    Browse the repository at this point in the history

  32. Show pausedAt indicator in story

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3b668db View commit details
    Browse the repository at this point in the history

  33. Better story data

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    b134d72 View commit details
    Browse the repository at this point in the history

  34. Add story book interaction row with parentId

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    18cf8c6 View commit details
    Browse the repository at this point in the history

  35. Better story data

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2e23d67 View commit details
    Browse the repository at this point in the history

  36. Collapse child interactions

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3285a9e View commit details
    Browse the repository at this point in the history

  37. Expand by default

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e39fb22 View commit details
    Browse the repository at this point in the history

  38. Tweak anonymous function color

    @ghengeveld @tmeasday
    ghengeveld authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    aa7f2b6 View commit details
    Browse the repository at this point in the history

  39. Update addons/interactions/src/components/Interaction/Interaction.tsx 

    Co-authored-by: Michael Shilman <[email protected]>
    @ghengeveld @shilman @tmeasday
    2 people authored and tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    6fdd19c View commit details
    Browse the repository at this point in the history

  40. Merge remote-tracking branch 'origin/next' into tom/sb-415-return-cle… 

    …anup-function-from-rendertodom
    @tmeasday
    tmeasday committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    7b313ae View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Use node14 in netlify

    @tmeasday
    tmeasday committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    f0169ca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into tom/sb-415-return-cleanup-function-from-rend… 

    …ertodom
    @shilman
    shilman committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    661011f View commit details
    Browse the repository at this point in the history