Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Allow a teardown function to be returned from
renderToDOM
#18457Core: Allow a teardown function to be returned from
renderToDOM
#18457Changes from 2 commits
4c80c21
06e4c29
95d3f32
3a57672
383b5b5
d7cb989
d66cb53
d2928de
31aef64
f1ae954
8335942
d410bd9
e1d7f08
d35bc15
f92dd04
2e9fb44
f19b470
d5b741e
3bcec76
1ea2f9c
136c121
ee7baf2
6f42962
edc79c9
3364473
ea77b6d
dbcf78b
6d540e0
1605cbb
1fa16ca
249496f
fcf5728
41913b6
2509e7e
3b668db
b134d72
18cf8c6
2e23d67
3285a9e
e39fb22
aa7f2b6
6fdd19c
7b313ae
f0169ca
661011f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we patch this back we should make sure we don't include this change (in fact should we take it out until we've considered this properly?)